From 86035c16447eb0ad7989975639f83bc4b4b26a27 Mon Sep 17 00:00:00 2001 From: Mingliang Liu Date: Thu, 16 Mar 2017 15:24:46 -0700 Subject: [PATCH] HADOOP-14192. Aliyun OSS FileSystem contract test should implement getTestBaseDir(). Contributed by Mingliang Liu --- .../oss/TestAliyunOSSFileSystemContract.java | 35 +++---------------- 1 file changed, 4 insertions(+), 31 deletions(-) diff --git a/hadoop-tools/hadoop-aliyun/src/test/java/org/apache/hadoop/fs/aliyun/oss/TestAliyunOSSFileSystemContract.java b/hadoop-tools/hadoop-aliyun/src/test/java/org/apache/hadoop/fs/aliyun/oss/TestAliyunOSSFileSystemContract.java index 3ebf5077b7..69ce694ab8 100644 --- a/hadoop-tools/hadoop-aliyun/src/test/java/org/apache/hadoop/fs/aliyun/oss/TestAliyunOSSFileSystemContract.java +++ b/hadoop-tools/hadoop-aliyun/src/test/java/org/apache/hadoop/fs/aliyun/oss/TestAliyunOSSFileSystemContract.java @@ -38,8 +38,8 @@ public class TestAliyunOSSFileSystemContract extends FileSystemContractBaseTest { public static final String TEST_FS_OSS_NAME = "test.fs.oss.name"; - private static String testRootPath = - AliyunOSSTestUtils.generateUniqueTestPath(); + private static Path testRootPath = + new Path(AliyunOSSTestUtils.generateUniqueTestPath()); @Override public void setUp() throws Exception { @@ -49,20 +49,8 @@ public void setUp() throws Exception { } @Override - public void tearDown() throws Exception { - if (fs != null) { - fs.delete(super.path(testRootPath), true); - } - super.tearDown(); - } - - @Override - protected Path path(String path) { - if (path.startsWith("/")) { - return super.path(testRootPath + path); - } else { - return super.path(testRootPath + "/" + path); - } + public Path getTestBaseDir() { + return testRootPath; } @Override @@ -228,19 +216,4 @@ public void testMkdirsForExistingFile() throws Exception { } } - public void testWorkingDirectory() throws Exception { - Path workDir = super.path(this.getDefaultWorkingDirectory()); - assertEquals(workDir, this.fs.getWorkingDirectory()); - this.fs.setWorkingDirectory(super.path(".")); - assertEquals(workDir, this.fs.getWorkingDirectory()); - this.fs.setWorkingDirectory(super.path("..")); - assertEquals(workDir.getParent(), this.fs.getWorkingDirectory()); - Path relativeDir = super.path("hadoop"); - this.fs.setWorkingDirectory(relativeDir); - assertEquals(relativeDir, this.fs.getWorkingDirectory()); - Path absoluteDir = super.path("/test/hadoop"); - this.fs.setWorkingDirectory(absoluteDir); - assertEquals(absoluteDir, this.fs.getWorkingDirectory()); - } - }