big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDDS-1941. Unused executor in SimpleContainerDownloader (#1367)

Browse Source
This commit is contained in:
Doroszlai, Attila 2019-08-28 23:59:49 +02:00 committed by Bharat Viswanadham
parent 6f2226a013
commit 872cdf48a6
1 changed files with 2 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/SimpleContainerDownloader.java
View File

@ -18,15 +18,10 @@
package org.apache.hadoop.ozone.container.replication; package org.apache.hadoop.ozone.container.replication;
import java.io.IOException;
import java.nio.file.Path; import java.nio.file.Path;
import java.nio.file.Paths; import java.nio.file.Paths;
import java.util.List; import java.util.List;
import java.util.concurrent.CompletableFuture; import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.ThreadFactory;
import java.util.concurrent.TimeUnit;
import java.util.function.Function; import java.util.function.Function;
import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.conf.Configuration;
@ -34,7 +29,6 @@
import org.apache.hadoop.hdds.protocol.DatanodeDetails.Port.Name; import org.apache.hadoop.hdds.protocol.DatanodeDetails.Port.Name;
import org.apache.hadoop.ozone.OzoneConfigKeys; import org.apache.hadoop.ozone.OzoneConfigKeys;
import com.google.common.util.concurrent.ThreadFactoryBuilder;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
@ -52,8 +46,6 @@ public class SimpleContainerDownloader implements ContainerDownloader {
private final Path workingDirectory; private final Path workingDirectory;
private ExecutorService executor;
public SimpleContainerDownloader(Configuration conf) { public SimpleContainerDownloader(Configuration conf) {
String workDirString = String workDirString =
@ -65,12 +57,6 @@ public SimpleContainerDownloader(Configuration conf) {
} else { } else {
workingDirectory = Paths.get(workDirString); workingDirectory = Paths.get(workDirString);
} }
ThreadFactory build = new ThreadFactoryBuilder().setDaemon(true)
.setNameFormat("Container downloader thread - %d").build();
executor = Executors.newSingleThreadExecutor(build);
LOG.info("Starting container downloader service to copy "
+ "containers to replicate.");
} }
@Override @Override
@ -110,11 +96,7 @@ public CompletableFuture<Path> getContainerDataFromReplicas(long containerId,
} }
@Override @Override
public void close() throws IOException { public void close() {
try { // noop
executor.awaitTermination(10, TimeUnit.SECONDS);
} catch (InterruptedException e) {
LOG.error("Can't stop container downloader gracefully", e);
}
} }
} }