diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java index df5ee0f819..1752cf7ed4 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java @@ -1579,62 +1579,53 @@ public static NameNode createNameNode(String argv[], Configuration conf) } setStartupOption(conf, startOpt); + boolean aborted = false; switch (startOpt) { - case FORMAT: { - boolean aborted = format(conf, startOpt.getForceFormat(), - startOpt.getInteractiveFormat()); - terminate(aborted ? 1 : 0); - return null; // avoid javac warning - } - case GENCLUSTERID: { - System.err.println("Generating new cluster id:"); - System.out.println(NNStorage.newClusterID()); - terminate(0); - return null; - } - case ROLLBACK: { - boolean aborted = doRollback(conf, true); - terminate(aborted ? 1 : 0); - return null; // avoid warning - } - case BOOTSTRAPSTANDBY: { - String toolArgs[] = Arrays.copyOfRange(argv, 1, argv.length); - int rc = BootstrapStandby.run(toolArgs, conf); - terminate(rc); - return null; // avoid warning - } - case INITIALIZESHAREDEDITS: { - boolean aborted = initializeSharedEdits(conf, - startOpt.getForceFormat(), - startOpt.getInteractiveFormat()); - terminate(aborted ? 1 : 0); - return null; // avoid warning - } - case BACKUP: - case CHECKPOINT: { - NamenodeRole role = startOpt.toNodeRole(); - DefaultMetricsSystem.initialize(role.toString().replace(" ", "")); - return new BackupNode(conf, role); - } - case RECOVER: { - NameNode.doRecovery(startOpt, conf); - return null; - } - case METADATAVERSION: { - printMetadataVersion(conf); - terminate(0); - return null; // avoid javac warning - } - case UPGRADEONLY: { - DefaultMetricsSystem.initialize("NameNode"); - new NameNode(conf); - terminate(0); - return null; - } - default: { - DefaultMetricsSystem.initialize("NameNode"); - return new NameNode(conf); - } + case FORMAT: + aborted = format(conf, startOpt.getForceFormat(), + startOpt.getInteractiveFormat()); + terminate(aborted ? 1 : 0); + return null; // avoid javac warning + case GENCLUSTERID: + System.err.println("Generating new cluster id:"); + System.out.println(NNStorage.newClusterID()); + terminate(0); + return null; + case ROLLBACK: + aborted = doRollback(conf, true); + terminate(aborted ? 1 : 0); + return null; // avoid warning + case BOOTSTRAPSTANDBY: + String[] toolArgs = Arrays.copyOfRange(argv, 1, argv.length); + int rc = BootstrapStandby.run(toolArgs, conf); + terminate(rc); + return null; // avoid warning + case INITIALIZESHAREDEDITS: + aborted = initializeSharedEdits(conf, + startOpt.getForceFormat(), + startOpt.getInteractiveFormat()); + terminate(aborted ? 1 : 0); + return null; // avoid warning + case BACKUP: + case CHECKPOINT: + NamenodeRole role = startOpt.toNodeRole(); + DefaultMetricsSystem.initialize(role.toString().replace(" ", "")); + return new BackupNode(conf, role); + case RECOVER: + NameNode.doRecovery(startOpt, conf); + return null; + case METADATAVERSION: + printMetadataVersion(conf); + terminate(0); + return null; // avoid javac warning + case UPGRADEONLY: + DefaultMetricsSystem.initialize("NameNode"); + new NameNode(conf); + terminate(0); + return null; + default: + DefaultMetricsSystem.initialize("NameNode"); + return new NameNode(conf); } }