big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-7194 Fix findbugs "inefficient new String constructor" warning in DFSClient#PATH (yzhang via cmccabe)

Browse Source
This commit is contained in:
Colin Patrick Mccabe 2014-10-06 15:29:09 -07:00
parent 687d83c9e1
commit 8dc6abf2f4
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
View File

@ -365,11 +365,15 @@ Release 2.7.0 - UNRELEASED
NEW FEATURES NEW FEATURES
IMPROVEMENTS IMPROVEMENTS
HDFS-7055. Add tracing to DFSInputStream (cmccabe) HDFS-7055. Add tracing to DFSInputStream (cmccabe)
OPTIMIZATIONS OPTIMIZATIONS
BUG FIXES BUG FIXES
HDFS-7194. Fix findbugs "inefficient new String constructor" warning in
DFSClient#PATH (yzhang via cmccabe)
Release 2.6.0 - UNRELEASED Release 2.6.0 - UNRELEASED

3
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
View File

@ -3174,8 +3174,7 @@ public SaslDataTransferClient getSaslDataTransferClient() {
return saslClient; return saslClient;
} }
private static final byte[] PATH = private static final byte[] PATH = "path".getBytes(Charset.forName("UTF-8"));
new String("path").getBytes(Charset.forName("UTF-8"));
TraceScope getPathTraceScope(String description, String path) { TraceScope getPathTraceScope(String description, String path) {
TraceScope scope = Trace.startSpan(description, traceSampler); TraceScope scope = Trace.startSpan(description, traceSampler);