From 9192f8446d5b669adc7d3a682f4b83bc795253bd Mon Sep 17 00:00:00 2001 From: Haohui Mai Date: Thu, 6 Mar 2014 08:13:40 +0000 Subject: [PATCH] HDFS-6058. Fix TestHDFSCLI failures after HADOOP-8691 change. Contributed by Akira Ajisaka and Haohui Mai. git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1574792 13f79535-47bb-0310-9956-ffa450edef68 --- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 3 + .../org/apache/hadoop/hdfs/TestDFSShell.java | 6 +- .../src/test/resources/testAclCLI.xml | 4 - .../src/test/resources/testHDFSConf.xml | 116 ------------------ .../java/org/apache/hadoop/cli/testMRConf.xml | 20 --- 5 files changed, 4 insertions(+), 145 deletions(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index 0e14ce12c7..eefa6d829a 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -692,6 +692,9 @@ Release 2.4.0 - UNRELEASED HDFS-6057. DomainSocketWatcher.watcherThread should be marked as daemon thread (cmccabe) + HDFS-6058. Fix TestHDFSCLI failures after HADOOP-8691 change. + (Akira Ajisaka via wheat9) + BREAKDOWN OF HDFS-5698 SUBTASKS AND RELATED JIRAS HDFS-5717. Save FSImage header in protobuf. (Haohui Mai via jing9) diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java index dd453644a0..0d45196189 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java @@ -184,10 +184,7 @@ public void testRecrusiveRm() throws IOException { public void testDu() throws IOException { Configuration conf = new HdfsConfiguration(); MiniDFSCluster cluster = new MiniDFSCluster.Builder(conf).numDataNodes(2).build(); - FileSystem fs = cluster.getFileSystem(); - assertTrue("Not a HDFS: "+fs.getUri(), - fs instanceof DistributedFileSystem); - final DistributedFileSystem dfs = (DistributedFileSystem)fs; + DistributedFileSystem fs = cluster.getFileSystem(); PrintStream psBackup = System.out; ByteArrayOutputStream out = new ByteArrayOutputStream(); PrintStream psOut = new PrintStream(out); @@ -224,7 +221,6 @@ public void testDu() throws IOException { assertTrue(returnString.contains("23")); } finally { - try {dfs.close();} catch (Exception e) {} System.setOut(psBackup); cluster.shutdown(); } diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testAclCLI.xml b/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testAclCLI.xml index 2edc46e5d7..0bc909f708 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testAclCLI.xml +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testAclCLI.xml @@ -901,10 +901,6 @@ -fs NAMENODE -rm -R /dir1 - - TokenComparator - Found 1 items - RegexpComparator ^drwxr-xr-x\+( )*-( )*[a-zA-z0-9]*( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/dir1/dir2 diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml b/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml index 5294b9b6fc..0ebe8e2f49 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml @@ -41,10 +41,6 @@ -fs NAMENODE -rm /file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/file1 @@ -63,10 +59,6 @@ -fs NAMENODE -rm file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*file1 @@ -117,10 +109,6 @@ -fs NAMENODE -rm -r /dir1 - - TokenComparator - Found 1 items - RegexpComparator ^drwxr-xr-x( )*-( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/dir1 @@ -138,10 +126,6 @@ -fs NAMENODE -rm -r dir1 - - TokenComparator - Found 1 items - RegexpComparator ^drwxr-xr-x( )*-( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*dir1 @@ -221,10 +205,6 @@ -fs NAMENODE -rm NAMENODE/file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*NAMENODE/file1 @@ -242,10 +222,6 @@ -fs NAMENODE -rm hdfs:///file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*hdfs:///file1 @@ -454,10 +430,6 @@ -fs NAMENODE -rm -r "/a path with" - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/a path with/whitespaces in directories/and file names @@ -476,10 +448,6 @@ -fs NAMENODE -rm -r "a path with" - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*a path with/whitespaces in directories/and file names @@ -498,10 +466,6 @@ -fs NAMENODE -rm -r "NAMENODE/a path with" - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*NAMENODE/a path with/whitespaces in directories/and file names @@ -1726,10 +1690,6 @@ -fs NAMENODE -rm /file2 : - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/file2 @@ -1887,10 +1847,6 @@ -fs NAMENODE -rm /user - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*file2 @@ -1913,10 +1869,6 @@ -fs NAMENODE -rm hdfs:///file2 : - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*hdfs:///file2 @@ -2066,10 +2018,6 @@ -fs NAMENODE -rm NAMENODE/file2 : - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*NAMENODE/file2 @@ -8719,10 +8667,6 @@ -fs NAMENODE -rm /file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rwxrwxrwx( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/file1 @@ -8742,10 +8686,6 @@ -fs NAMENODE -rm file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-rw-rw-( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*file1 @@ -8832,10 +8772,6 @@ -fs NAMENODE -rm /file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-rw-rw-( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/file1 @@ -8854,10 +8790,6 @@ -fs NAMENODE -rm file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-rw-rw-( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*file1 @@ -10356,10 +10288,6 @@ -fs NAMENODE -rm hdfs:///file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rwxrwxrwx( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*hdfs:///file1 @@ -10412,10 +10340,6 @@ -fs NAMENODE -rm hdfs:///file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-rw-rw-( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*hdfs:///file1 @@ -11175,10 +11099,6 @@ -fs NAMENODE -rm NAMENODE/file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rwxrwxrwx( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*NAMENODE/file1 @@ -11231,10 +11151,6 @@ -fs NAMENODE -rm NAMENODE/file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-rw-rw-( )*1( )*USERNAME( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*NAMENODE/file1 @@ -11994,10 +11910,6 @@ -fs NAMENODE -rm hdfs:///file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*newowner( )*newgroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*hdfs:///file1 @@ -12421,10 +12333,6 @@ -fs NAMENODE -rm /file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*newowner( )*newgroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/file1 @@ -12443,10 +12351,6 @@ -fs NAMENODE -rm file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*newowner( )*newgroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*file1 @@ -13273,10 +13177,6 @@ -fs NAMENODE -rm NAMENODE/file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*newowner( )*newgroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*NAMENODE/file1 @@ -13700,10 +13600,6 @@ -fs NAMENODE -rm /file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*USERNAME( )*newgroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/file1 @@ -13722,10 +13618,6 @@ -fs NAMENODE -rm file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*USERNAME( )*newgroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*file1 @@ -14518,10 +14410,6 @@ -fs NAMENODE -rm hdfs:///file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*USERNAME( )*newgroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*hdfs:///file1 @@ -14928,10 +14816,6 @@ -fs NAMENODE -rm NAMENODE/file1 - - TokenComparator - Found 1 items - RegexpComparator ^-rw-r--r--( )*1( )*USERNAME( )*newgroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*NAMENODE/file1 diff --git a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/cli/testMRConf.xml b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/cli/testMRConf.xml index bf52aae236..3eeb411a8d 100644 --- a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/cli/testMRConf.xml +++ b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/cli/testMRConf.xml @@ -312,10 +312,6 @@ -fs NAMENODE -rmr /* - - TokenComparator - Found 1 items - RegexpComparator ^[drwx-]+( )*[0-9\-]+( )*[a-zA-Z0-9]+( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/dir1/test.har @@ -339,10 +335,6 @@ -fs NAMENODE -rmr /* - - TokenComparator - Found 1 items - RegexpComparator ^[drwx-]+( )*[0-9\-]+( )*[a-zA-Z0-9]+( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/dest/test.har @@ -362,10 +354,6 @@ -fs NAMENODE -rmr /* - - TokenComparator - Found 1 items - RegexpComparator ^[drwx-]+( )*[0-9\-]+( )*[a-zA-Z0-9]+( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/dir1/test.har @@ -385,10 +373,6 @@ -fs NAMENODE -rmr /* - - TokenComparator - Found 1 items - RegexpComparator ^[drwx-]+( )*[0-9\-]+( )*[a-zA-Z0-9]+( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/dest/test.har @@ -467,10 +451,6 @@ -fs NAMENODE -rmr /* - - TokenComparator - Found 1 items - RegexpComparator ^[drwx-]+( )*[0-9\-]+( )*[a-zA-Z0-9]+( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/dest/test1.har