HDDS-1281. Fix the findbug issue caused by HDDS-1163. Contributed by Aravindan Vijayan.

hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java

@@ -677,7 +677,7 @@ public void check() throws StorageContainerException {
 
     KeyValueContainerCheck checker =
         new KeyValueContainerCheck(containerData.getMetadataPath(), config,
-            containerId, containerData);
+            containerId);
 
     switch (level) {
     case FAST_CHECK:

hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerCheck.java

@@ -52,20 +52,18 @@ public class KeyValueContainerCheck {
   private static final Logger LOG = LoggerFactory.getLogger(Container.class);
 
   private long containerID;
-  private KeyValueContainerData inMemContainerData; //from caller, maybe null
   private KeyValueContainerData onDiskContainerData; //loaded from fs/disk
   private Configuration checkConfig;
 
   private String metadataPath;
 
   public KeyValueContainerCheck(String metadataPath, Configuration conf,
-      long containerID, KeyValueContainerData containerData) {
+      long containerID) {
     Preconditions.checkArgument(metadataPath != null);
 
     this.checkConfig = conf;
     this.containerID = containerID;
     this.onDiskContainerData = null;
-    this.inMemContainerData = containerData;
     this.metadataPath = metadataPath;
   }
 

hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueContainerCheck.java

@@ -111,7 +111,7 @@ public TestKeyValueContainerCheck(String metadataImpl) {
 
     KeyValueContainerCheck kvCheck =
         new KeyValueContainerCheck(containerData.getMetadataPath(), conf,
-            containerID, containerData);
+            containerID);
 
     // first run checks on a Open Container
     error = kvCheck.fastCheck();