From 92ebd466c75275118107e6ec665cf50e337a29e7 Mon Sep 17 00:00:00 2001
From: Inigo Goiri <inigoiri@apache.org>
Date: Tue, 15 May 2018 10:21:42 -0700
Subject: [PATCH] HDFS-13551. TestMiniDFSCluster#testClusterSetStorageCapacity
 does not shut down cluster. Contributed by Anbang Hu.

---
 .../hadoop/hdfs/TestMiniDFSCluster.java       | 44 +++++++++++--------
 1 file changed, 25 insertions(+), 19 deletions(-)

diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMiniDFSCluster.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMiniDFSCluster.java
index afc977fc0e..d60e0253a8 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMiniDFSCluster.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMiniDFSCluster.java
@@ -108,29 +108,35 @@ public void testClusterSetStorageCapacity() throws Throwable {
             capacities,
             defaultBlockSize,
             fileLen);
-    verifyStorageCapacity(cluster, capacities);
+    try {
+      verifyStorageCapacity(cluster, capacities);
 
-    /* restart all data nodes */
-    cluster.restartDataNodes();
-    cluster.waitActive();
-    verifyStorageCapacity(cluster, capacities);
+      /* restart all data nodes */
+      cluster.restartDataNodes();
+      cluster.waitActive();
+      verifyStorageCapacity(cluster, capacities);
 
-    /* restart all name nodes */
-    cluster.restartNameNodes();
-    cluster.waitActive();
-    verifyStorageCapacity(cluster, capacities);
+      /* restart all name nodes */
+      cluster.restartNameNodes();
+      cluster.waitActive();
+      verifyStorageCapacity(cluster, capacities);
 
-    /* restart all name nodes firstly and data nodes then */
-    cluster.restartNameNodes();
-    cluster.restartDataNodes();
-    cluster.waitActive();
-    verifyStorageCapacity(cluster, capacities);
+      /* restart all name nodes firstly and data nodes then */
+      cluster.restartNameNodes();
+      cluster.restartDataNodes();
+      cluster.waitActive();
+      verifyStorageCapacity(cluster, capacities);
 
-    /* restart all data nodes firstly and name nodes then */
-    cluster.restartDataNodes();
-    cluster.restartNameNodes();
-    cluster.waitActive();
-    verifyStorageCapacity(cluster, capacities);
+      /* restart all data nodes firstly and name nodes then */
+      cluster.restartDataNodes();
+      cluster.restartNameNodes();
+      cluster.waitActive();
+      verifyStorageCapacity(cluster, capacities);
+    } finally {
+      if (cluster != null) {
+        cluster.shutdown();
+      }
+    }
   }
 
   private void verifyStorageCapacity(