From 990e4945562974a285f31d8385230b03a9d557e7 Mon Sep 17 00:00:00 2001
From: Steve Loughran <stevel@apache.org>
Date: Sat, 28 Sep 2013 13:59:13 +0000
Subject: [PATCH] HADOOP-8545 findbugs patches from the final -037 patch

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1527189 13f79535-47bb-0310-9956-ffa450edef68
---
 .../dev-support/findbugs-exclude.xml          | 34 +++++++++++++++++++
 hadoop-tools/hadoop-openstack/pom.xml         | 20 ++++++-----
 2 files changed, 45 insertions(+), 9 deletions(-)
 create mode 100644 hadoop-tools/hadoop-openstack/dev-support/findbugs-exclude.xml

diff --git a/hadoop-tools/hadoop-openstack/dev-support/findbugs-exclude.xml b/hadoop-tools/hadoop-openstack/dev-support/findbugs-exclude.xml
new file mode 100644
index 0000000000..cfb75c7308
--- /dev/null
+++ b/hadoop-tools/hadoop-openstack/dev-support/findbugs-exclude.xml
@@ -0,0 +1,34 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed under the Apache License, Version 2.0 (the "License");
+  ~   you may not use this file except in compliance with the License.
+  ~   You may obtain a copy of the License at
+  ~   
+  ~    http://www.apache.org/licenses/LICENSE-2.0
+  ~   
+  ~   Unless required by applicable law or agreed to in writing, software
+  ~   distributed under the License is distributed on an "AS IS" BASIS,
+  ~   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~   See the License for the specific language governing permissions and
+  ~   limitations under the License. See accompanying LICENSE file.
+  -->
+<FindBugsFilter>
+
+  <!--
+  OpenStack Swift FS module -closes streams in a different method
+  from where they are opened.
+  -->
+  <Match>
+    <Class name="org.apache.hadoop.fs.swift.snative.SwiftNativeOutputStream"/>
+    <Method name="uploadFileAttempt"/>
+    <Bug pattern="OBL_UNSATISFIED_OBLIGATION"/>
+    <Bug code="OBL"/>
+  </Match>
+  <Match>
+    <Class name="org.apache.hadoop.fs.swift.snative.SwiftNativeOutputStream"/>
+    <Method name="uploadFilePartAttempt"/>
+    <Bug pattern="OBL_UNSATISFIED_OBLIGATION"/>
+    <Bug code="OBL"/>
+  </Match>
+
+</FindBugsFilter>
diff --git a/hadoop-tools/hadoop-openstack/pom.xml b/hadoop-tools/hadoop-openstack/pom.xml
index ab36c24e46..bc6e391b16 100644
--- a/hadoop-tools/hadoop-openstack/pom.xml
+++ b/hadoop-tools/hadoop-openstack/pom.xml
@@ -66,7 +66,17 @@
 
   <build>
     <plugins>
-
+      <plugin>
+        <groupId>org.codehaus.mojo</groupId>
+        <artifactId>findbugs-maven-plugin</artifactId>
+        <configuration>
+          <findbugsXmlOutput>true</findbugsXmlOutput>
+          <xmlOutput>true</xmlOutput>
+          <excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
+          </excludeFilterFile>
+          <effort>Max</effort>
+        </configuration>
+      </plugin>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-site-plugin</artifactId>
@@ -131,14 +141,6 @@
       <scope>compile</scope>
     </dependency>
 
-    <!-- Used for mocking dependencies -->
-    <dependency>
-      <groupId>org.mockito</groupId>
-      <artifactId>mockito-all</artifactId>
-      <version>1.8.5</version>
-      <scope>test</scope>
-    </dependency>
-
     <dependency>
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>