big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MAPREDUCE-6797. Job history server scans can become blocked on a single, slow entry. Contributed by Prabhu Joseph

Browse Source
This commit is contained in:
Jason Lowe 2016-11-14 20:20:50 +00:00
parent ff0b99eafe
commit 99c2bbd337
1 changed files with 25 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/HistoryFileManager.java
View File

@ -231,16 +231,15 @@ public HistoryFileInfo addIfAbsent(HistoryFileInfo fileInfo) {
JobId firstMoveFailedKey = null; JobId firstMoveFailedKey = null;
int moveFailedCount = 0; int moveFailedCount = 0;
while(cache.size() > maxSize && keys.hasNext()) { while (cache.size() > maxSize && keys.hasNext()) {
JobId key = keys.next(); JobId key = keys.next();
HistoryFileInfo firstValue = cache.get(key); HistoryFileInfo firstValue = cache.get(key);
if(firstValue != null) { if (firstValue != null) {
synchronized(firstValue) {
if (firstValue.isMovePending()) { if (firstValue.isMovePending()) {
if(firstValue.didMoveFail() && if (firstValue.didMoveFail() &&
firstValue.jobIndexInfo.getFinishTime() <= cutoff) { firstValue.jobIndexInfo.getFinishTime() <= cutoff) {
cache.remove(key); cache.remove(key);
//Now lets try to delete it // Now lets try to delete it
try { try {
firstValue.delete(); firstValue.delete();
} catch (IOException e) { } catch (IOException e) {
@ -265,7 +264,6 @@ public HistoryFileInfo addIfAbsent(HistoryFileInfo fileInfo) {
} }
} }
} }
}
// Log output only for first jobhisotry in pendings to restrict // Log output only for first jobhisotry in pendings to restrict
// the total number of logs. // the total number of logs.
if (inIntermediateCount > 0) { if (inIntermediateCount > 0) {