big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-14419. Avoid repeated calls to the listOpenFiles function. Contributed by HuangTao.

Browse Source
This commit is contained in:
Wei-Chiu Chuang 2019-07-30 16:50:06 -07:00
parent 3ae775d740
commit 99f88c30cb
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
View File

@ -25,6 +25,7 @@
import java.util.Collections;
import java.util.Comparator;
import java.util.HashSet;
import java.util.Iterator;
import java.util.List;
import java.util.NavigableSet;
import java.util.Set;
@ -302,7 +303,9 @@ public BatchedListEntries<OpenFileEntry> getUnderConstructionFiles(
int count = 0;
String fullPathName = null;
for (Long inodeId: inodeIds) {
Iterator<Long> inodeIdIterator = inodeIds.iterator();
while (inodeIdIterator.hasNext()) {
Long inodeId = inodeIdIterator.next();
final INodeFile inodeFile =
fsnamesystem.getFSDirectory().getInode(inodeId).asFile();
if (!inodeFile.isUnderConstruction()) {
@ -323,7 +326,8 @@ public BatchedListEntries<OpenFileEntry> getUnderConstructionFiles(
break;
}
}
boolean hasMore = (numResponses < remainingLeases.size());
// avoid rescanning all leases when we have checked all leases already
boolean hasMore = inodeIdIterator.hasNext();
return new BatchedListEntries<>(openFileEntries, hasMore);
}