Revert "HADOOP-16870. Use spotbugs-maven-plugin instead of findbugs-maven-plugin (#2454)"

This reverts commit 4cf3531583.
This commit is contained in:
Akira Ajisaka 2021-02-19 11:09:10 +09:00
parent 2970bd93f3
commit 9a298d180d
No known key found for this signature in database
GPG Key ID: C1EDBB9CA400FD50
33 changed files with 106 additions and 98 deletions

View File

@ -139,7 +139,7 @@ Maven build goals:
* Compile : mvn compile [-Pnative] * Compile : mvn compile [-Pnative]
* Run tests : mvn test [-Pnative] [-Pshelltest] * Run tests : mvn test [-Pnative] [-Pshelltest]
* Create JAR : mvn package * Create JAR : mvn package
* Run spotbugs : mvn compile spotbugs:spotbugs * Run findbugs : mvn compile findbugs:findbugs
* Run checkstyle : mvn compile checkstyle:checkstyle * Run checkstyle : mvn compile checkstyle:checkstyle
* Install JAR in M2 cache : mvn install * Install JAR in M2 cache : mvn install
* Deploy JAR to Maven repo : mvn deploy * Deploy JAR to Maven repo : mvn deploy

View File

@ -120,11 +120,11 @@ pipeline {
YETUS_ARGS+=("--proclimit=5500") YETUS_ARGS+=("--proclimit=5500")
YETUS_ARGS+=("--dockermemlimit=22g") YETUS_ARGS+=("--dockermemlimit=22g")
# -1 spotbugs issues that show up prior to the patch being applied # -1 findbugs issues that show up prior to the patch being applied
YETUS_ARGS+=("--spotbugs-strict-precheck") YETUS_ARGS+=("--findbugs-strict-precheck")
# rsync these files back into the archive dir # rsync these files back into the archive dir
YETUS_ARGS+=("--archive-list=checkstyle-errors.xml,spotbugsXml.xml") YETUS_ARGS+=("--archive-list=checkstyle-errors.xml,findbugsXml.xml")
# URL for user-side presentation in reports and such to our artifacts # URL for user-side presentation in reports and such to our artifacts
# (needs to match the archive bits below) # (needs to match the archive bits below)

View File

@ -482,7 +482,7 @@ function personality_file_tests
fi fi
if [[ ${filename} =~ \.java$ ]]; then if [[ ${filename} =~ \.java$ ]]; then
add_test spotbugs add_test findbugs
fi fi
} }
@ -550,7 +550,7 @@ function shadedclient_rebuild
echo_and_redirect "${logfile}" \ echo_and_redirect "${logfile}" \
"${MAVEN}" "${MAVEN_ARGS[@]}" verify -fae --batch-mode -am \ "${MAVEN}" "${MAVEN_ARGS[@]}" verify -fae --batch-mode -am \
"${modules[@]}" \ "${modules[@]}" \
-Dtest=NoUnitTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true -Dtest=NoUnitTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true
count=$("${GREP}" -c '\[ERROR\]' "${logfile}") count=$("${GREP}" -c '\[ERROR\]' "${logfile}")
if [[ ${count} -gt 0 ]]; then if [[ ${count} -gt 0 ]]; then

View File

@ -44,6 +44,7 @@ RUN apt-get -q update \
cmake \ cmake \
curl \ curl \
doxygen \ doxygen \
findbugs \
fuse \ fuse \
g++ \ g++ \
gcc \ gcc \
@ -90,16 +91,7 @@ RUN apt-get -q update \
ENV MAVEN_HOME /usr ENV MAVEN_HOME /usr
# JAVA_HOME must be set in Maven >= 3.5.0 (MNG-6003) # JAVA_HOME must be set in Maven >= 3.5.0 (MNG-6003)
ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64 ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64
ENV FINDBUGS_HOME /usr
#######
# Install SpotBugs 4.0.6
#######
RUN mkdir -p /opt/spotbugs \
&& curl -L -s -S https://github.com/spotbugs/spotbugs/releases/download/4.0.6/spotbugs-4.0.6.tgz \
-o /opt/spotbugs.tgz \
&& tar xzf /opt/spotbugs.tgz --strip-components 1 -C /opt/spotbugs \
&& chmod +x /opt/spotbugs/bin/*
ENV SPOTBUGS_HOME /opt/spotbugs
####### #######
# Install Boost 1.72 (1.71 ships with Focal) # Install Boost 1.72 (1.71 ships with Focal)

View File

@ -48,6 +48,7 @@ RUN apt-get -q update \
cmake \ cmake \
curl \ curl \
doxygen \ doxygen \
findbugs \
fuse \ fuse \
g++ \ g++ \
gcc \ gcc \
@ -94,16 +95,7 @@ RUN apt-get -q update \
ENV MAVEN_HOME /usr ENV MAVEN_HOME /usr
# JAVA_HOME must be set in Maven >= 3.5.0 (MNG-6003) # JAVA_HOME must be set in Maven >= 3.5.0 (MNG-6003)
ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-arm64 ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-arm64
ENV FINDBUGS_HOME /usr
#######
# Install SpotBugs 4.0.6
#######
RUN mkdir -p /opt/spotbugs \
&& curl -L -s -S https://github.com/spotbugs/spotbugs/releases/download/4.0.6/spotbugs-4.0.6.tgz \
-o /opt/spotbugs.tgz \
&& tar xzf /opt/spotbugs.tgz --strip-components 1 -C /opt/spotbugs \
&& chmod +x /opt/spotbugs/bin/*
ENV SPOTBUGS_HOME /opt/spotbugs
####### #######
# Install Boost 1.72 (1.71 ships with Focal) # Install Boost 1.72 (1.71 ships with Focal)

View File

@ -64,9 +64,10 @@
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml <excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile> </excludeFilterFile>

View File

@ -237,8 +237,8 @@
</executions> </executions>
</plugin> </plugin>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile> <excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
</configuration> </configuration>

View File

@ -237,8 +237,8 @@
</executions> </executions>
</plugin> </plugin>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml <excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml
</excludeFilterFile> </excludeFilterFile>

View File

@ -53,8 +53,8 @@
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml <excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml
</excludeFilterFile> </excludeFilterFile>

View File

@ -107,8 +107,8 @@
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml <excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml
</excludeFilterFile> </excludeFilterFile>

View File

@ -163,9 +163,10 @@
</resources> </resources>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${project.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile> <excludeFilterFile>${project.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<effort>Max</effort> <effort>Max</effort>

View File

@ -337,8 +337,8 @@
</executions> </executions>
</plugin> </plugin>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile> <excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
</configuration> </configuration>

View File

@ -157,9 +157,10 @@
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${mr.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile> <excludeFilterFile>${mr.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<effort>Max</effort> <effort>Max</effort>

View File

@ -138,9 +138,10 @@
</plugin> </plugin>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${mr.examples.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile> <excludeFilterFile>${mr.examples.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<effort>Max</effort> <effort>Max</effort>

View File

@ -178,9 +178,10 @@
</executions> </executions>
</plugin> </plugin>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${mr.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile> <excludeFilterFile>${mr.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<effort>Max</effort> <effort>Max</effort>
@ -298,9 +299,12 @@
<reporting> <reporting>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<!-- until we have reporting management cf. MSITE-443 -->
<version>2.3.2</version>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
</configuration> </configuration>
</plugin> </plugin>

View File

@ -89,10 +89,11 @@
</executions> </executions>
</plugin> </plugin>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile> <excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
<fork>true</fork>
<maxHeap>2048</maxHeap> <maxHeap>2048</maxHeap>
</configuration> </configuration>
</plugin> </plugin>

View File

@ -101,6 +101,7 @@
<zookeeper.version>3.5.6</zookeeper.version> <zookeeper.version>3.5.6</zookeeper.version>
<curator.version>4.2.0</curator.version> <curator.version>4.2.0</curator.version>
<findbugs.version>3.0.5</findbugs.version> <findbugs.version>3.0.5</findbugs.version>
<spotbugs.version>4.0.6</spotbugs.version>
<dnsjava.version>2.1.7</dnsjava.version> <dnsjava.version>2.1.7</dnsjava.version>
<guava.version>27.0-jre</guava.version> <guava.version>27.0-jre</guava.version>
@ -1853,6 +1854,18 @@
<artifactId>maven-war-plugin</artifactId> <artifactId>maven-war-plugin</artifactId>
<version>${maven-war-plugin.version}</version> <version>${maven-war-plugin.version}</version>
</plugin> </plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
<version>${findbugs.version}</version>
<dependencies>
<dependency>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs</artifactId>
<version>${spotbugs.version}</version>
</dependency>
</dependencies>
</plugin>
<plugin> <plugin>
<groupId>org.codehaus.mojo</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>make-maven-plugin</artifactId> <artifactId>make-maven-plugin</artifactId>
@ -2086,6 +2099,10 @@
</filesets> </filesets>
</configuration> </configuration>
</plugin> </plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
</plugin>
<plugin> <plugin>
<groupId>org.apache.maven.plugins</groupId> <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId> <artifactId>maven-antrun-plugin</artifactId>

View File

@ -58,9 +58,10 @@
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml <excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile> </excludeFilterFile>

View File

@ -194,9 +194,10 @@
</executions> </executions>
</plugin> </plugin>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile> <excludeFilterFile>
${basedir}/dev-support/findbugs-exclude.xml ${basedir}/dev-support/findbugs-exclude.xml

View File

@ -399,9 +399,10 @@
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml <excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile> </excludeFilterFile>

View File

@ -50,9 +50,10 @@
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml <excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile> </excludeFilterFile>

View File

@ -108,9 +108,10 @@
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml <excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile> </excludeFilterFile>

View File

@ -87,9 +87,10 @@
</configuration> </configuration>
</plugin> </plugin>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile> <excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<effort>Max</effort> <effort>Max</effort>

View File

@ -123,9 +123,10 @@
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile> <excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<effort>Max</effort> <effort>Max</effort>

View File

@ -39,9 +39,10 @@
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<effort>Max</effort> <effort>Max</effort>
</configuration> </configuration>

View File

@ -66,9 +66,10 @@
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml <excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile> </excludeFilterFile>

View File

@ -102,9 +102,10 @@
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile> <excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<effort>Max</effort> <effort>Max</effort>

View File

@ -108,9 +108,10 @@
</executions> </executions>
</plugin> </plugin>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile> <excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<effort>Max</effort> <effort>Max</effort>

View File

@ -129,9 +129,10 @@
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile> <excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<effort>Max</effort> <effort>Max</effort>

View File

@ -389,8 +389,8 @@
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<includeTests>true</includeTests> <includeTests>true</includeTests>
</configuration> </configuration>

View File

@ -39,9 +39,10 @@
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<excludeFilterFile>${yarn.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile> <excludeFilterFile>${yarn.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<effort>Max</effort> <effort>Max</effort>

View File

@ -204,9 +204,12 @@
<reporting> <reporting>
<plugins> <plugins>
<plugin> <plugin>
<groupId>com.github.spotbugs</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>spotbugs-maven-plugin</artifactId> <artifactId>findbugs-maven-plugin</artifactId>
<!-- until we have reporting management cf. MSITE-443 -->
<version>2.3.2</version>
<configuration> <configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
</configuration> </configuration>
</plugin> </plugin>

18
pom.xml
View File

@ -113,8 +113,6 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x
<maven-checkstyle-plugin.version>3.1.0</maven-checkstyle-plugin.version> <maven-checkstyle-plugin.version>3.1.0</maven-checkstyle-plugin.version>
<checkstyle.version>8.29</checkstyle.version> <checkstyle.version>8.29</checkstyle.version>
<dependency-check-maven.version>1.4.3</dependency-check-maven.version> <dependency-check-maven.version>1.4.3</dependency-check-maven.version>
<spotbugs.version>4.0.6</spotbugs.version>
<spotbugs-maven-plugin.version>4.0.4</spotbugs-maven-plugin.version>
<shell-executable>bash</shell-executable> <shell-executable>bash</shell-executable>
@ -344,18 +342,6 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x
<artifactId>dependency-check-maven</artifactId> <artifactId>dependency-check-maven</artifactId>
<version>${dependency-check-maven.version}</version> <version>${dependency-check-maven.version}</version>
</plugin> </plugin>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>${spotbugs-maven-plugin.version}</version>
<dependencies>
<dependency>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs</artifactId>
<version>${spotbugs.version}</version>
</dependency>
</dependencies>
</plugin>
</plugins> </plugins>
</pluginManagement> </pluginManagement>
@ -457,10 +443,6 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x
<artifactId>dependency-check-maven</artifactId> <artifactId>dependency-check-maven</artifactId>
<version>${dependency-check-maven.version}</version> <version>${dependency-check-maven.version}</version>
</plugin> </plugin>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
</plugin>
</plugins> </plugins>
</build> </build>