big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

YARN-6211. Synchronization improvement for moveApplicationAcrossQueues and updateApplicationPriority. Contributed by Bibin A Chundatt.

Browse Source
This commit is contained in:
Sunil G 2017-02-23 14:19:07 +05:30
parent 13d4bcfe35
commit a207aa9930
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
View File

@ -1228,7 +1228,8 @@ public MoveApplicationAcrossQueuesResponse moveApplicationAcrossQueues(
} }
try { try {
this.rmAppManager.moveApplicationAcrossQueue(applicationId, this.rmAppManager.moveApplicationAcrossQueue(
application.getApplicationId(),
request.getTargetQueue()); request.getTargetQueue());
} catch (YarnException ex) { } catch (YarnException ex) {
RMAuditLogger.logFailure(callerUGI.getShortUserName(), RMAuditLogger.logFailure(callerUGI.getShortUserName(),
@ -1662,7 +1663,8 @@ public UpdateApplicationPriorityResponse updateApplicationPriority(
} }
try { try {
rmAppManager.updateApplicationPriority(callerUGI, applicationId, rmAppManager.updateApplicationPriority(callerUGI,
application.getApplicationId(),
newAppPriority); newAppPriority);
} catch (YarnException ex) { } catch (YarnException ex) {
RMAuditLogger.logFailure(callerUGI.getShortUserName(), RMAuditLogger.logFailure(callerUGI.getShortUserName(),

5
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java
View File

@ -53,7 +53,6 @@
import org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppImpl; import org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppImpl;
import org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppMetrics; import org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppMetrics;
import org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppRecoverEvent; import org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppRecoverEvent;
import org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppState;
import org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttempt; import org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttempt;
import org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl; import org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl;
import org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils; import org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils;
@ -612,7 +611,7 @@ public void updateApplicationPriority(UserGroupInformation callerUGI,
RMApp app = this.rmContext.getRMApps().get(applicationId); RMApp app = this.rmContext.getRMApps().get(applicationId);
synchronized (applicationId) { synchronized (applicationId) {
if (app.isAppInCompletedStates()) { if (app == null || app.isAppInCompletedStates()) {
return; return;
} }
@ -658,7 +657,7 @@ public void moveApplicationAcrossQueue(ApplicationId applicationId, String targe
// 2. Update this information to state-store // 2. Update this information to state-store
// 3. Perform real move operation and update in-memory data structures. // 3. Perform real move operation and update in-memory data structures.
synchronized (applicationId) { synchronized (applicationId) {
if (app.isAppInCompletedStates()) { if (app == null || app.isAppInCompletedStates()) {
return; return;
} }