From a393e84c6f57d50a471fc902dfd07ca1b4128a0e Mon Sep 17 00:00:00 2001 From: Rohith Sharma K S Date: Thu, 16 Feb 2017 18:00:25 +0530 Subject: [PATCH] YARN-6200. Reverting since the same functionality achieved by YARN-1623. Revert "YARN-5068. Expose scheduler queue to application master. (Harish Jaiprakash via rohithsharmaks)" This reverts commit b7ac85259c7d20c33bef9c9cb40b8aabcab70755. --- .../hadoop/yarn/api/ApplicationConstants.java | 7 ------- .../resourcemanager/amlauncher/AMLauncher.java | 14 -------------- .../TestApplicationMasterLauncher.java | 5 ----- 3 files changed, 26 deletions(-) diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationConstants.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationConstants.java index 760e251564..64bcc440d0 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationConstants.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationConstants.java @@ -159,13 +159,6 @@ public enum Environment { */ LD_LIBRARY_PATH("LD_LIBRARY_PATH"), - /** - * $YARN_RESOURCEMANAGER_APPLICATION_QUEUE - * The queue into which the app was submitted/launched. - */ - YARN_RESOURCEMANAGER_APPLICATION_QUEUE( - "YARN_RESOURCEMANAGER_APPLICATION_QUEUE"), - /** * $HADOOP_CONF_DIR * Final, non-modifiable. diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/AMLauncher.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/AMLauncher.java index d33360b4f3..05f9f47b91 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/AMLauncher.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/AMLauncher.java @@ -51,7 +51,6 @@ import org.apache.hadoop.yarn.api.records.ContainerLaunchContext; import org.apache.hadoop.yarn.api.records.NodeId; import org.apache.hadoop.yarn.client.NMProxy; -import org.apache.hadoop.yarn.conf.YarnConfiguration; import org.apache.hadoop.yarn.event.EventHandler; import org.apache.hadoop.yarn.exceptions.YarnException; import org.apache.hadoop.yarn.ipc.YarnRPC; @@ -189,9 +188,6 @@ private ContainerLaunchContext createAMContainerLaunchContext( ContainerLaunchContext container = applicationMasterContext.getAMContainerSpec(); - // Populate the current queue name in the environment variable. - setupQueueNameEnv(container, applicationMasterContext); - // Finalize the container setupTokens(container, containerID); // set the flow context optionally for timeline service v.2 @@ -200,16 +196,6 @@ private ContainerLaunchContext createAMContainerLaunchContext( return container; } - private void setupQueueNameEnv(ContainerLaunchContext container, - ApplicationSubmissionContext applicationMasterContext) { - String queueName = applicationMasterContext.getQueue(); - if (queueName == null) { - queueName = YarnConfiguration.DEFAULT_QUEUE_NAME; - } - container.getEnvironment().put(ApplicationConstants.Environment - .YARN_RESOURCEMANAGER_APPLICATION_QUEUE.key(), queueName); - } - @Private @VisibleForTesting protected void setupTokens( diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterLauncher.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterLauncher.java index 9a46e011dd..08b180fc41 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterLauncher.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterLauncher.java @@ -101,7 +101,6 @@ private static final class MyContainerManagerImpl implements String nmHostAtContainerManager = null; long submitTimeAtContainerManager; int maxAppAttempts; - private String queueName; @Override public StartContainersResponse @@ -130,8 +129,6 @@ private static final class MyContainerManagerImpl implements submitTimeAtContainerManager = Long.parseLong(env.get(ApplicationConstants.APP_SUBMIT_TIME_ENV)); maxAppAttempts = YarnConfiguration.DEFAULT_RM_AM_MAX_ATTEMPTS; - queueName = env.get(ApplicationConstants.Environment - .YARN_RESOURCEMANAGER_APPLICATION_QUEUE.key()); return StartContainersResponse.newInstance( new HashMap(), new ArrayList(), new HashMap()); @@ -231,8 +228,6 @@ public void testAMLaunchAndCleanup() throws Exception { containerManager.nmHostAtContainerManager); Assert.assertEquals(YarnConfiguration.DEFAULT_RM_AM_MAX_ATTEMPTS, containerManager.maxAppAttempts); - Assert.assertEquals(YarnConfiguration.DEFAULT_QUEUE_NAME, - containerManager.queueName); MockAM am = new MockAM(rm.getRMContext(), rm .getApplicationMasterService(), appAttemptId);