From a8070259f8384021bd6196e7343f1cc23de89b1c Mon Sep 17 00:00:00 2001 From: Xiaoyu Yao Date: Wed, 14 Oct 2015 14:41:13 -0700 Subject: [PATCH] Revert "HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. Contributed by Xiaoyu Yao." This reverts commit 3d5085595286c0231f66543d1509247ad4bb5739. --- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 2 -- .../apache/hadoop/hdfs/server/datanode/VolumeScanner.java | 7 ++++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index 3c66951a80..127cb0d230 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -2060,8 +2060,6 @@ Release 2.8.0 - UNRELEASED HDFS-9187. Fix null pointer error in Globber when FS was not constructed via FileSystem#createFileSystem (cmccabe) - HDFS-9210. Fix some misuse of %n in VolumeScanner#printStats. (xyao) - Release 2.7.2 - UNRELEASED INCOMPATIBLE CHANGES diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java index d6700f0003..212e13b369 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java @@ -216,8 +216,9 @@ private static double positiveMsToHours(long ms) { } public void printStats(StringBuilder p) { - p.append(String.format("Block scanner information for volume %s with base" + - " path %s%n" + volume.getStorageID(), volume.getBasePath())); + p.append("Block scanner information for volume " + + volume.getStorageID() + " with base path " + volume.getBasePath() + + "%n"); synchronized (stats) { p.append(String.format("Bytes verified in last hour : %57d%n", stats.bytesScannedInPastHour)); @@ -244,7 +245,7 @@ public void printStats(StringBuilder p) { stats.lastBlockScanned.toString()))); p.append(String.format("More blocks to scan in period : %57s%n", !stats.eof)); - p.append(String.format("%n")); + p.append("%n"); } }