diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotDiffListingInfo.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotDiffListingInfo.java index 8861a1f0ec..4b03c4f0d5 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotDiffListingInfo.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotDiffListingInfo.java @@ -116,7 +116,7 @@ boolean addDirDiff(long dirId, byte[][] parent, ChildrenDiff diff) { if (lastIndex == -1 || lastIndex >= clist.size()) { final List dlist = diff.getDeletedUnmodifiable(); - int size = dlist.size(); + int size = clist.size(); ListIterator iterator = lastIndex != -1 ? dlist.listIterator(lastIndex - size): dlist.listIterator(); while (iterator.hasNext()) { @@ -130,6 +130,10 @@ boolean addDirDiff(long dirId, byte[][] parent, ChildrenDiff diff) { deletedList.add(e); } else { setLastPath(parent); + // the offset will be set to created list + iterator index in the + // deleted list so that it points to the exact entry in the deleted + // list post checking the created list in the next iteration of rpc + // call setLastIndex(size + iterator.nextIndex()); return false; } diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotDiffReport.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotDiffReport.java index 18ec3c581d..f6fdec8f0d 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotDiffReport.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotDiffReport.java @@ -1400,6 +1400,58 @@ public void testDiffReportWithRpcLimit2() throws Exception { DFSUtil.string2Bytes("dir3/file3"))); } + /** + * Tests to verify the diff report with maximum SnapsdiffReportEntries limit + * over an rpc being set to 3. + * @throws Exception + */ + @Test + public void testDiffReportWithRpcLimit3() throws Exception { + final Path root = new Path("/"); + hdfs.mkdirs(root); + Path path = new Path(root, "dir1"); + hdfs.mkdirs(path); + for (int j = 1; j <= 4; j++) { + final Path file = new Path(path, "file" + j); + DFSTestUtil.createFile(hdfs, file, BLOCKSIZE, REPLICATION, SEED); + } + SnapshotTestHelper.createSnapshot(hdfs, root, "s0"); + path = new Path(root, "dir1"); + for (int j = 1; j <= 4; j++) { + final Path file = new Path(path, "file" + j); + hdfs.delete(file, false); + } + for (int j = 5; j <= 10; j++) { + final Path file = new Path(path, "file" + j); + DFSTestUtil.createFile(hdfs, file, BLOCKSIZE, REPLICATION, SEED); + } + + SnapshotTestHelper.createSnapshot(hdfs, root, "s1"); + verifyDiffReport(root, "s0", "s1", + new DiffReportEntry(DiffType.MODIFY, DFSUtil.string2Bytes("")), + new DiffReportEntry(DiffType.MODIFY, DFSUtil.string2Bytes("dir1")), + new DiffReportEntry(DiffType.CREATE, + DFSUtil.string2Bytes("dir1/file5")), + new DiffReportEntry(DiffType.CREATE, + DFSUtil.string2Bytes("dir1/file6")), + new DiffReportEntry(DiffType.CREATE, + DFSUtil.string2Bytes("dir1/file7")), + new DiffReportEntry(DiffType.CREATE, + DFSUtil.string2Bytes("dir1/file8")), + new DiffReportEntry(DiffType.CREATE, + DFSUtil.string2Bytes("dir1/file9")), + new DiffReportEntry(DiffType.CREATE, + DFSUtil.string2Bytes("dir1/file10")), + new DiffReportEntry(DiffType.DELETE, + DFSUtil.string2Bytes("dir1/file1")), + new DiffReportEntry(DiffType.DELETE, + DFSUtil.string2Bytes("dir1/file2")), + new DiffReportEntry(DiffType.DELETE, + DFSUtil.string2Bytes("dir1/file3")), + new DiffReportEntry(DiffType.DELETE, + DFSUtil.string2Bytes("dir1/file4"))); + } + private void verifyDiffReportForGivenReport(Path dirPath, String from, String to, SnapshotDiffReport report, DiffReportEntry... entries) throws IOException {