big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HADOOP-9241. DU refresh interval is not configurable. (harsh)

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1502954 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Harsh J 2013-07-14 10:46:37 +00:00
parent b980f2aa4e
commit adfd2fa314
5 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hadoop-common-project/hadoop-common/CHANGES.txt
View File

@ -287,6 +287,8 @@ Release 2.3.0 - UNRELEASED
IMPROVEMENTS IMPROVEMENTS
HADOOP-9241. DU refresh interval is not configurable (harsh)
OPTIMIZATIONS OPTIMIZATIONS
BUG FIXES BUG FIXES

4
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
View File

@ -54,6 +54,10 @@ public class CommonConfigurationKeysPublic {
public static final String FS_DF_INTERVAL_KEY = "fs.df.interval"; public static final String FS_DF_INTERVAL_KEY = "fs.df.interval";
/** Default value for FS_DF_INTERVAL_KEY */ /** Default value for FS_DF_INTERVAL_KEY */
public static final long FS_DF_INTERVAL_DEFAULT = 60000; public static final long FS_DF_INTERVAL_DEFAULT = 60000;
/** See <a href="{@docRoot}/../core-default.html">core-default.xml</a> */
public static final String FS_DU_INTERVAL_KEY = "fs.du.interval";
/** Default value for FS_DU_INTERVAL_KEY */
public static final long FS_DU_INTERVAL_DEFAULT = 600000;
//Defaults are not specified for following keys //Defaults are not specified for following keys

5
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DU.java
View File

@ -20,6 +20,7 @@
import org.apache.hadoop.classification.InterfaceAudience; import org.apache.hadoop.classification.InterfaceAudience;
import org.apache.hadoop.classification.InterfaceStability; import org.apache.hadoop.classification.InterfaceStability;
import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.CommonConfigurationKeys;
import org.apache.hadoop.util.Shell; import org.apache.hadoop.util.Shell;
import java.io.BufferedReader; import java.io.BufferedReader;
@ -64,8 +65,8 @@ public DU(File path, long interval) throws IOException {
* @throws IOException if we fail to refresh the disk usage * @throws IOException if we fail to refresh the disk usage
*/ */
public DU(File path, Configuration conf) throws IOException { public DU(File path, Configuration conf) throws IOException {
this(path, 600000L); this(path, conf.getLong(CommonConfigurationKeys.FS_DU_INTERVAL_KEY,
//10 minutes default refresh interval CommonConfigurationKeys.FS_DU_INTERVAL_DEFAULT));
} }
/** /**

6
hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
View File

@ -464,6 +464,12 @@
<description>Disk usage statistics refresh interval in msec.</description> <description>Disk usage statistics refresh interval in msec.</description>
</property> </property>
<property>
<name>fs.du.interval</name>
<value>600000</value>
<description>File space usage statistics refresh interval in msec.</description>
</property>
<property> <property>
<name>fs.s3.block.size</name> <name>fs.s3.block.size</name>
<value>67108864</value> <value>67108864</value>

7
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDU.java
View File

@ -24,6 +24,9 @@
import java.io.RandomAccessFile; import java.io.RandomAccessFile;
import java.util.Random; import java.util.Random;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.CommonConfigurationKeys;
/** This test makes sure that "DU" does not get to run on each call to getUsed */ /** This test makes sure that "DU" does not get to run on each call to getUsed */
public class TestDU extends TestCase { public class TestDU extends TestCase {
final static private File DU_DIR = new File( final static private File DU_DIR = new File(
@ -106,7 +109,9 @@ public void testDU() throws IOException, InterruptedException {
public void testDUGetUsedWillNotReturnNegative() throws IOException { public void testDUGetUsedWillNotReturnNegative() throws IOException {
File file = new File(DU_DIR, "data"); File file = new File(DU_DIR, "data");
assertTrue(file.createNewFile()); assertTrue(file.createNewFile());
DU du = new DU(file, 10000); Configuration conf = new Configuration();
conf.setLong(CommonConfigurationKeys.FS_DU_INTERVAL_KEY, 10000L);
DU du = new DU(file, conf);
du.decDfsUsed(Long.MAX_VALUE); du.decDfsUsed(Long.MAX_VALUE);
long duSize = du.getUsed(); long duSize = du.getUsed();
assertTrue(String.valueOf(duSize), duSize >= 0L); assertTrue(String.valueOf(duSize), duSize >= 0L);