YARN-3789. Improve logs for LeafQueue#activateApplications(). Contributed

by Bibin A Chundatt.
This commit is contained in:
Devaraj K 2015-06-16 14:03:22 +05:30
parent 32e39d8a29
commit b039e69bb0
2 changed files with 12 additions and 8 deletions

View File

@ -306,6 +306,9 @@ Release 2.8.0 - UNRELEASED
YARN-3785. Support for Resource as an argument during submitApp call in MockRM YARN-3785. Support for Resource as an argument during submitApp call in MockRM
test class. (Sunil G via xgong) test class. (Sunil G via xgong)
YARN-3789. Improve logs for LeafQueue#activateApplications().
(Bibin A Chundatt via devaraj)
OPTIMIZATIONS OPTIMIZATIONS
YARN-3339. TestDockerContainerExecutor should pull a single image and not YARN-3339. TestDockerContainerExecutor should pull a single image and not

View File

@ -56,7 +56,6 @@
import org.apache.hadoop.yarn.factory.providers.RecordFactoryProvider; import org.apache.hadoop.yarn.factory.providers.RecordFactoryProvider;
import org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager; import org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager;
import org.apache.hadoop.yarn.security.AccessType; import org.apache.hadoop.yarn.security.AccessType;
import org.apache.hadoop.yarn.server.resourcemanager.RMContext;
import org.apache.hadoop.yarn.server.resourcemanager.nodelabels.RMNodeLabelsManager; import org.apache.hadoop.yarn.server.resourcemanager.nodelabels.RMNodeLabelsManager;
import org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttempt; import org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttempt;
import org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.RMContainer; import org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.RMContainer;
@ -604,7 +603,7 @@ private synchronized void activateApplications() {
for (Iterator<FiCaSchedulerApp> i=pendingApplications.iterator(); for (Iterator<FiCaSchedulerApp> i=pendingApplications.iterator();
i.hasNext(); ) { i.hasNext(); ) {
FiCaSchedulerApp application = i.next(); FiCaSchedulerApp application = i.next();
ApplicationId applicationId = application.getApplicationId();
// Check am resource limit // Check am resource limit
Resource amIfStarted = Resource amIfStarted =
Resources.add(application.getAMResource(), queueUsage.getAMUsed()); Resources.add(application.getAMResource(), queueUsage.getAMUsed());
@ -624,7 +623,9 @@ private synchronized void activateApplications() {
" single application in queue, it is likely set too low." + " single application in queue, it is likely set too low." +
" skipping enforcement to allow at least one application to start"); " skipping enforcement to allow at least one application to start");
} else { } else {
LOG.info("not starting application as amIfStarted exceeds amLimit"); LOG.info("Not activating application " + applicationId
+ " as amIfStarted: " + amIfStarted + " exceeds amLimit: "
+ amLimit);
continue; continue;
} }
} }
@ -645,8 +646,9 @@ private synchronized void activateApplications() {
" single application in queue for user, it is likely set too low." + " single application in queue for user, it is likely set too low." +
" skipping enforcement to allow at least one application to start"); " skipping enforcement to allow at least one application to start");
} else { } else {
LOG.info("not starting application as amIfStarted exceeds " + LOG.info("Not activating application " + applicationId
"userAmLimit"); + " for user: " + user + " as userAmIfStarted: "
+ userAmIfStarted + " exceeds userAmLimit: " + userAMLimit);
continue; continue;
} }
} }
@ -657,9 +659,8 @@ private synchronized void activateApplications() {
metrics.incAMUsed(application.getUser(), application.getAMResource()); metrics.incAMUsed(application.getUser(), application.getAMResource());
metrics.setAMResouceLimitForUser(application.getUser(), userAMLimit); metrics.setAMResouceLimitForUser(application.getUser(), userAMLimit);
i.remove(); i.remove();
LOG.info("Application " + application.getApplicationId() + LOG.info("Application " + applicationId + " from user: "
" from user: " + application.getUser() + + application.getUser() + " activated in queue: " + getQueueName());
" activated in queue: " + getQueueName());
} }
} }