MAPREDUCE-5259. TestTaskLog fails on Windows because of path separators missmatch. Contributed by Ivan Mitic.

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1492364 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Chris Nauroth 2013-06-12 18:54:56 +00:00
parent c9fce677b3
commit b090bc1c21
2 changed files with 10 additions and 3 deletions

View File

@ -508,6 +508,9 @@ Release 2.1.0-beta - UNRELEASED
MAPREDUCE-5315. DistCp reports success even on failure. (mithun and jlowe MAPREDUCE-5315. DistCp reports success even on failure. (mithun and jlowe
via daryn) via daryn)
MAPREDUCE-5259. TestTaskLog fails on Windows because of path separators
missmatch. (Ivan Mitic via cnauroth)
BREAKDOWN OF HADOOP-8562 SUBTASKS BREAKDOWN OF HADOOP-8562 SUBTASKS
MAPREDUCE-4739. Some MapReduce tests fail to find winutils. MAPREDUCE-4739. Some MapReduce tests fail to find winutils.

View File

@ -55,7 +55,8 @@ public void testTaskLog() throws IOException {
when(taid.toString()).thenReturn("JobId"); when(taid.toString()).thenReturn("JobId");
File f = TaskLog.getTaskLogFile(taid, true, LogName.STDOUT); File f = TaskLog.getTaskLogFile(taid, true, LogName.STDOUT);
assertTrue(f.getAbsolutePath().endsWith("testString/stdout")); assertTrue(f.getAbsolutePath().endsWith("testString"
+ File.separatorChar + "stdout"));
// test getRealTaskLogFileLocation // test getRealTaskLogFileLocation
@ -69,11 +70,14 @@ public void testTaskLog() throws IOException {
TaskLog.syncLogs("location", taid, true); TaskLog.syncLogs("location", taid, true);
assertTrue(indexFile.getAbsolutePath().endsWith( assertTrue(indexFile.getAbsolutePath().endsWith(
"userlogs/job_job_0001/JobId.cleanup/log.index")); "userlogs" + File.separatorChar + "job_job_0001"
+ File.separatorChar + "JobId.cleanup"
+ File.separatorChar + "log.index"));
f = TaskLog.getRealTaskLogFileLocation(taid, true, LogName.DEBUGOUT); f = TaskLog.getRealTaskLogFileLocation(taid, true, LogName.DEBUGOUT);
if (f != null) { if (f != null) {
assertTrue(f.getAbsolutePath().endsWith("location/debugout")); assertTrue(f.getAbsolutePath().endsWith("location"
+ File.separatorChar + "debugout"));
FileUtils.copyFile(indexFile, f); FileUtils.copyFile(indexFile, f);
} }
// test obtainLogDirOwner // test obtainLogDirOwner