From b1e883132b8b0a9678b37cef4eb1b2e04f0200e7 Mon Sep 17 00:00:00 2001 From: Robert Joseph Evans Date: Wed, 9 May 2012 14:08:28 +0000 Subject: [PATCH] HADOOP-8354. test-patch findbugs may fail if a dependent module is changed Contributed by Tom White and Robert Evans. git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1336213 13f79535-47bb-0310-9956-ffa450edef68 --- dev-support/test-patch.sh | 19 +++++++++++++++++++ .../hadoop-common/CHANGES.txt | 3 +++ 2 files changed, 22 insertions(+) diff --git a/dev-support/test-patch.sh b/dev-support/test-patch.sh index ff52bd353d..90757a1d8b 100755 --- a/dev-support/test-patch.sh +++ b/dev-support/test-patch.sh @@ -528,6 +528,24 @@ $JIRA_COMMENT_FOOTER" return 0 } +############################################################################### +### Install the new jars so tests and findbugs can find all of the updated jars +buildAndInstall () { + echo "" + echo "" + echo "======================================================================" + echo "======================================================================" + echo " Installing all of the jars" + echo "======================================================================" + echo "======================================================================" + echo "" + echo "" + echo "$MVN install -Dmaven.javadoc.skip=true -DskipTests -D${PROJECT_NAME}PatchProcess" + $MVN install -Dmaven.javadoc.skip=true -DskipTests -D${PROJECT_NAME}PatchProcess + return $? +} + + ############################################################################### ### Check there are no changes in the number of Findbugs warnings checkFindbugsWarnings () { @@ -891,6 +909,7 @@ checkEclipseGeneration ### Checkstyle not implemented yet #checkStyle #(( RESULT = RESULT + $? )) +buildAndInstall checkFindbugsWarnings (( RESULT = RESULT + $? )) checkReleaseAuditWarnings diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index 0cc39a58b4..283158e850 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -129,6 +129,9 @@ Trunk (unreleased changes) HADOOP-8339. jenkins complaining about 16 javadoc warnings (Tom White and Robert Evans via tgraves) + HADOOP-8354. test-patch findbugs may fail if a dependent module is changed + (Tom White and Robert Evans) + OPTIMIZATIONS HADOOP-7761. Improve the performance of raw comparisons. (todd)