From b431c6924a6374f8babac57ad08065890bf2e979 Mon Sep 17 00:00:00 2001 From: He Xiaoqiao Date: Mon, 1 Feb 2021 23:27:14 +0800 Subject: [PATCH] HDFS-15792. ClasscastException while loading FSImage. Contributed by Renukaprasad C. --- .../hdfs/server/namenode/AclFeature.java | 9 +- .../hadoop/hdfs/util/ReferenceCountMap.java | 7 +- .../hdfs/util/TestReferenceCountMap.java | 113 ++++++++++++++++++ 3 files changed, 121 insertions(+), 8 deletions(-) create mode 100644 hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/util/TestReferenceCountMap.java diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclFeature.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclFeature.java index d18079ee89..6b2baa4e31 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclFeature.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclFeature.java @@ -19,6 +19,7 @@ package org.apache.hadoop.hdfs.server.namenode; import java.util.Arrays; +import java.util.concurrent.atomic.AtomicInteger; import org.apache.hadoop.classification.InterfaceAudience; import org.apache.hadoop.fs.permission.AclEntry; @@ -34,7 +35,7 @@ public class AclFeature implements INode.Feature, ReferenceCounter { public static final ImmutableList EMPTY_ENTRY_LIST = ImmutableList.of(); - private int refCount = 0; + private AtomicInteger value = new AtomicInteger(); private final int [] entries; @@ -84,16 +85,16 @@ public int hashCode() { @Override public int getRefCount() { - return refCount; + return value.get(); } @Override public int incrementAndGetRefCount() { - return ++refCount; + return value.incrementAndGet(); } @Override public int decrementAndGetRefCount() { - return (refCount > 0) ? --refCount : 0; + return value.updateAndGet(i -> i > 0 ? i - 1 : i); } } diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/ReferenceCountMap.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/ReferenceCountMap.java index f24d1aa9df..6c40b29c0d 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/ReferenceCountMap.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/ReferenceCountMap.java @@ -17,8 +17,8 @@ */ package org.apache.hadoop.hdfs.util; -import java.util.HashMap; import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; import org.apache.hadoop.classification.InterfaceAudience; import org.apache.hadoop.classification.InterfaceStability; @@ -37,7 +37,7 @@ @InterfaceStability.Evolving public class ReferenceCountMap { - private Map referenceMap = new HashMap(); + private Map referenceMap = new ConcurrentHashMap<>(); /** * Add the reference. If the instance already present, just increase the @@ -47,10 +47,9 @@ public class ReferenceCountMap { * @return Referenced instance */ public E put(E key) { - E value = referenceMap.get(key); + E value = referenceMap.putIfAbsent(key, key); if (value == null) { value = key; - referenceMap.put(key, value); } value.incrementAndGetRefCount(); return value; diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/util/TestReferenceCountMap.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/util/TestReferenceCountMap.java new file mode 100644 index 0000000000..a0019de581 --- /dev/null +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/util/TestReferenceCountMap.java @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdfs.util; + +import org.apache.hadoop.hdfs.server.namenode.AclFeature; +import org.junit.Assert; +import org.junit.Test; + +/** + * Verify ReferenceCount map in concurrent scenarios + * + */ +public class TestReferenceCountMap { + //Add these number of references in loop + public static final int LOOP_COUNTER = 10000; + //Use 2 global features + AclFeature aclFeature1 = new AclFeature(new int[]{1}); + AclFeature aclFeature2 = new AclFeature(new int[]{2}); + + @Test + public void testReferenceCountMap() throws Exception{ + ReferenceCountMap countMap = new ReferenceCountMap<>(); + countMap.put(aclFeature1); + countMap.put(aclFeature2); + Assert.assertEquals(1, countMap.getReferenceCount(aclFeature1)); + Assert.assertEquals(1, countMap.getReferenceCount(aclFeature2)); + + countMap.put(aclFeature1); + countMap.put(aclFeature2); + Assert.assertEquals(2, countMap.getReferenceCount(aclFeature1)); + Assert.assertEquals(2, countMap.getReferenceCount(aclFeature2)); + + countMap.put(aclFeature1); + Assert.assertEquals(3, countMap.getReferenceCount(aclFeature1)); + countMap.put(aclFeature1); + Assert.assertEquals(4, countMap.getReferenceCount(aclFeature1)); + Assert.assertEquals(2, countMap.getReferenceCount(aclFeature2)); + + //Delete operations: + countMap.remove(aclFeature1); + countMap.remove(aclFeature2); + Assert.assertEquals(3, countMap.getReferenceCount(aclFeature1)); + Assert.assertEquals(1, countMap.getReferenceCount(aclFeature2)); + + //Verify unique elements in map + Assert.assertEquals(2, countMap.getUniqueElementsSize()); + } + + @Test + public void testRefCountMapConcurrently() throws Exception{ + ReferenceCountMap countMap = new ReferenceCountMap<>(); + + PutThread putThread1 = new PutThread(countMap); + putThread1.start(); + PutThread putThread2 = new PutThread(countMap); + putThread2.start(); + RemoveThread removeThread1 = new RemoveThread(countMap); + + putThread1.join(); + putThread2.join(); + Assert.assertEquals(2 * LOOP_COUNTER, countMap.getReferenceCount(aclFeature1)); + Assert.assertEquals(2 * LOOP_COUNTER, countMap.getReferenceCount(aclFeature2)); + + removeThread1.start(); + removeThread1.join(); + Assert.assertEquals(LOOP_COUNTER, countMap.getReferenceCount(aclFeature1)); + Assert.assertEquals(LOOP_COUNTER, countMap.getReferenceCount(aclFeature2)); + } + + class PutThread extends Thread{ + ReferenceCountMap referenceCountMap; + public PutThread(ReferenceCountMap referenceCountMap){ + this.referenceCountMap = referenceCountMap; + } + @Override + public void run() { + for (int i = 0; i < LOOP_COUNTER; i++) { + referenceCountMap.put(aclFeature1); + referenceCountMap.put(aclFeature2); + } + } + }; + + class RemoveThread extends Thread{ + ReferenceCountMap referenceCountMap; + public RemoveThread(ReferenceCountMap referenceCountMap){ + this.referenceCountMap = referenceCountMap; + } + @Override + public void run() { + for (int i = 0; i < LOOP_COUNTER; i++) { + referenceCountMap.remove(aclFeature1); + referenceCountMap.remove(aclFeature2); + } + } + }; +}