big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-8116. Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula.

Browse Source
This commit is contained in:
Xiaoyu Yao 2015-06-06 18:47:45 -07:00
parent 71de367c5e
commit b61b489995
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
View File

@ -606,6 +606,9 @@ Release 2.8.0 - UNRELEASED
HDFS-8432. Introduce a minimum compatible layout version to allow downgrade HDFS-8432. Introduce a minimum compatible layout version to allow downgrade
in more rolling upgrade use cases. (cnauroth) in more rolling upgrade use cases. (cnauroth)
HDFS-8116. Cleanup uncessary if LOG.isDebugEnabled() from
RollingWindowManager. (Brahma Reddy Battula via xyao)
OPTIMIZATIONS OPTIMIZATIONS
HDFS-8026. Trace FSOutputSummer#writeChecksumChunks rather than HDFS-8026. Trace FSOutputSummer#writeChecksumChunks rather than

8
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
View File

@ -187,11 +187,9 @@ public void recordMetric(long time, String command, String user, long delta) {
*/ */
public TopWindow snapshot(long time) { public TopWindow snapshot(long time) {
TopWindow window = new TopWindow(windowLenMs); TopWindow window = new TopWindow(windowLenMs);
if (LOG.isDebugEnabled()) { Set<String> metricNames = metricMap.keySet();
Set<String> metricNames = metricMap.keySet(); LOG.debug("iterating in reported metrics, size={} values={}",
LOG.debug("iterating in reported metrics, size={} values={}", metricNames.size(), metricNames);
metricNames.size(), metricNames);
}
for (Map.Entry<String, RollingWindowMap> entry : metricMap.entrySet()) { for (Map.Entry<String, RollingWindowMap> entry : metricMap.entrySet()) {
String metricName = entry.getKey(); String metricName = entry.getKey();
RollingWindowMap rollingWindows = entry.getValue(); RollingWindowMap rollingWindows = entry.getValue();