big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-11027: libbhdfs++: Don't retry if there is an authentication failure. Contributed by Xiaowei Zhu.

Browse Source
This commit is contained in:
James 2016-10-24 10:47:15 -04:00 committed by James Clampffer
parent 59a3926946
commit b7d9a0f827
3 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/include/hdfspp/status.h
View File

@ -62,6 +62,9 @@ class Status {
// get error code
int code() const { return code_; }
// if retry can possibly recover an error
bool notWorthRetry() const;
enum Code {
kOk = 0,
kInvalidArgument = static_cast<unsigned>(std::errc::invalid_argument),

13
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/status.cc
View File

@ -22,6 +22,7 @@
#include <sstream>
#include <cstring>
#include <map>
#include <set>
namespace hdfs {
@ -49,6 +50,12 @@ const static std::map<std::string, int> kKnownServerExceptionClasses = {
{kPathIsNotEmptyDirectoryException, Status::kPathIsNotEmptyDirectory}
};
// Errors that retry cannot fix. TODO: complete the list.
const static std::set<int> noRetryExceptions = {
Status::kPermissionDenied,
Status::kAuthenticationFailed,
Status::kAccessControlException
};
Status::Status(int code, const char *msg1)
: code_(code) {
@ -120,7 +127,7 @@ Status Status::Exception(const char *exception_class_name, const char *error_mes
}
Status Status::Error(const char *error_message) {
return Status(kAuthenticationFailed, error_message);
return Exception("Exception", error_message);
}
Status Status::AuthenticationFailed() {
@ -147,4 +154,8 @@ std::string Status::ToString() const {
return ss.str();
}
bool Status::notWorthRetry() const {
return noRetryExceptions.find(code_) != noRetryExceptions.end();
}
}

4
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/rpc/rpc_engine.cc
View File

@ -322,7 +322,9 @@ void RpcEngine::RpcCommsError(
RetryAction retry = RetryAction::fail(""); // Default to fail
if (retry_policy()) {
if (status.notWorthRetry()) {
retry = RetryAction::fail(status.ToString().c_str());
} else if (retry_policy()) {
retry = retry_policy()->ShouldRetry(status, req->IncrementRetryCount(), req->get_failover_count(), true);
}