big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-15223. FSCK fails if one namenode is not available. Contributed by Ayush Saxena.

Browse Source
This commit is contained in:
Ayush Saxena 2020-03-19 21:23:13 +05:30
parent f2d3ac2a3f
commit bb41ddaf1e
2 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java
View File

@ -57,10 +57,14 @@
import com.google.common.base.Joiner; import com.google.common.base.Joiner;
import com.google.common.base.Preconditions; import com.google.common.base.Preconditions;
import com.google.common.collect.Lists; import com.google.common.collect.Lists;
import org.slf4j.LoggerFactory;
@InterfaceAudience.Private @InterfaceAudience.Private
public class HAUtil { public class HAUtil {
public static final org.slf4j.Logger LOG =
LoggerFactory.getLogger(HAUtil.class.getName());
private static final String[] HA_SPECIAL_INDEPENDENT_KEYS = new String[]{ private static final String[] HA_SPECIAL_INDEPENDENT_KEYS = new String[]{
DFS_NAMENODE_RPC_ADDRESS_KEY, DFS_NAMENODE_RPC_ADDRESS_KEY,
DFS_NAMENODE_RPC_BIND_HOST_KEY, DFS_NAMENODE_RPC_BIND_HOST_KEY,
@ -273,9 +277,14 @@ public static InetSocketAddress getAddressOfActive(FileSystem fs)
List<ClientProtocol> namenodes = List<ClientProtocol> namenodes =
getProxiesForAllNameNodesInNameservice(dfsConf, nsId); getProxiesForAllNameNodesInNameservice(dfsConf, nsId);
for (ClientProtocol proxy : namenodes) { for (ClientProtocol proxy : namenodes) {
try {
if (proxy.getHAServiceState().equals(HAServiceState.ACTIVE)) { if (proxy.getHAServiceState().equals(HAServiceState.ACTIVE)) {
inAddr = RPC.getServerAddress(proxy); inAddr = RPC.getServerAddress(proxy);
} }
} catch (Exception e) {
//Ignore the exception while connecting to a namenode.
LOG.debug("Error while connecting to namenode", e);
}
} }
} else { } else {
DFSClient dfsClient = dfs.getClient(); DFSClient dfsClient = dfs.getClient();

5
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHAFsck.java
View File

@ -76,6 +76,11 @@ public void testHaFsck() throws Exception {
cluster.transitionToStandby(0); cluster.transitionToStandby(0);
cluster.transitionToActive(1); cluster.transitionToActive(1);
runFsck(conf);
// Stop one standby namenode, FSCK should still be successful, since there
// is one Active namenode available
cluster.getNameNode(0).stop();
runFsck(conf); runFsck(conf);
} finally { } finally {
if (fs != null) { if (fs != null) {