big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HADOOP-15402. Prevent double logout of UGI's LoginContext

Browse Source 
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
This commit is contained in:
Daryn Sharp 2018-04-25 17:05:42 +09:00 committed by Owen O'Malley
parent 6f655aed3b
commit bbc8dfcb8b
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
View File

@ -47,6 +47,7 @@
import java.util.Map;
import java.util.Set;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicReference;
import javax.security.auth.DestroyFailedException;
@ -1843,6 +1844,7 @@ static LoginParams getDefaults() {
private static class HadoopLoginContext extends LoginContext {
private final String appName;
private final HadoopConfiguration conf;
private AtomicBoolean isLoggedIn = new AtomicBoolean();
HadoopLoginContext(String appName, Subject subject,
HadoopConfiguration conf) throws LoginException {
@ -1875,6 +1877,7 @@ public void login() throws LoginException {
long start = Time.monotonicNow();
try {
super.login();
isLoggedIn.set(true);
metric = metrics.loginSuccess;
} finally {
metric.add(Time.monotonicNow() - start);
@ -1885,8 +1888,7 @@ public void login() throws LoginException {
@Override
public void logout() throws LoginException {
synchronized(getSubjectLock()) {
if (this.getSubject() != null
&& !this.getSubject().getPrivateCredentials().isEmpty()) {
if (isLoggedIn.compareAndSet(true, false)) {
super.logout();
}
}