big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-16585.Add @VisibleForTesting in Dispatcher.java (#4337)

Browse Source 
Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com>

Reviewed-by: Tao Li <tomscut@apache.org>
Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
This commit is contained in:
Ashutosh Gupta 2022-05-26 22:18:15 +01:00 committed by GitHub
parent 297f0f6d6a
commit bee538f785
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
View File

@ -241,6 +241,7 @@ public class PendingMove {
private DDatanode proxySource; private DDatanode proxySource;
private StorageGroup target; private StorageGroup target;
@VisibleForTesting
PendingMove(Source source, StorageGroup target) { PendingMove(Source source, StorageGroup target) {
this.source = source; this.source = source;
this.target = target; this.target = target;
@ -282,6 +283,7 @@ private boolean chooseBlockAndProxy() {
/** /**
* @return true if the given block is good for the tentative move. * @return true if the given block is good for the tentative move.
*/ */
@VisibleForTesting
boolean markMovedIfGoodBlock(DBlock block, StorageType targetStorageType) { boolean markMovedIfGoodBlock(DBlock block, StorageType targetStorageType) {
synchronized (block) { synchronized (block) {
synchronized (movedBlocks) { synchronized (movedBlocks) {
@ -1361,6 +1363,7 @@ public static boolean checkForSuccess(
* 2. the block does not have a replica/internalBlock on the target; * 2. the block does not have a replica/internalBlock on the target;
* 3. doing the move does not reduce the number of racks that the block has * 3. doing the move does not reduce the number of racks that the block has
*/ */
@VisibleForTesting
boolean isGoodBlockCandidate(StorageGroup source, StorageGroup target, boolean isGoodBlockCandidate(StorageGroup source, StorageGroup target,
StorageType targetStorageType, DBlock block) { StorageType targetStorageType, DBlock block) {
if (source.equals(target)) { if (source.equals(target)) {