From c01bee010832ca31d8e60e5461181cdf05140602 Mon Sep 17 00:00:00 2001 From: Rohith Sharma K S Date: Wed, 27 Jan 2016 08:23:02 +0530 Subject: [PATCH] YARN-4573. Fix test failure in TestRMAppTransitions#testAppRunningKill and testAppKilledKilled. (Takashi Ohnishi via rohithsharmaks) --- hadoop-yarn-project/CHANGES.txt | 3 +++ .../resourcemanager/rmapp/TestRMAppTransitions.java | 9 +++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hadoop-yarn-project/CHANGES.txt b/hadoop-yarn-project/CHANGES.txt index 435eb68b02..2fbecdb358 100644 --- a/hadoop-yarn-project/CHANGES.txt +++ b/hadoop-yarn-project/CHANGES.txt @@ -162,6 +162,9 @@ Release 2.9.0 - UNRELEASED YARN-4612. Fix rumen and scheduler load simulator handle killed tasks properly. (Ming Ma via xgong) + YARN-4573. Fix test failure in TestRMAppTransitions#testAppRunningKill and + testAppKilledKilled. (Takashi Ohnishi via rohithsharmaks) + Release 2.8.0 - UNRELEASED INCOMPATIBLE CHANGES diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/TestRMAppTransitions.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/TestRMAppTransitions.java index f2f09de98a..293c0b6a4c 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/TestRMAppTransitions.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/TestRMAppTransitions.java @@ -275,7 +275,7 @@ protected RMApp createNewTestApp(ApplicationSubmissionContext submissionContext) // Test expected newly created app state private static void testAppStartState(ApplicationId applicationId, String user, String name, String queue, RMApp application) { - Assert.assertTrue("application start time is not greater then 0", + Assert.assertTrue("application start time is not greater than 0", application.getStartTime() > 0); Assert.assertTrue("application start time is before currentTime", application.getStartTime() <= System.currentTimeMillis()); @@ -300,7 +300,7 @@ private static void testAppStartState(ApplicationId applicationId, // test to make sure times are set when app finishes private static void assertStartTimeSet(RMApp application) { - Assert.assertTrue("application start time is not greater then 0", + Assert.assertTrue("application start time is not greater than 0", application.getStartTime() > 0); Assert.assertTrue("application start time is before currentTime", application.getStartTime() <= System.currentTimeMillis()); @@ -319,9 +319,9 @@ private static void assertFinalAppStatus(FinalApplicationStatus status, RMApp ap // test to make sure times are set when app finishes private void assertTimesAtFinish(RMApp application) { assertStartTimeSet(application); - Assert.assertTrue("application finish time is not greater then 0", + Assert.assertTrue("application finish time is not greater than 0", (application.getFinishTime() > 0)); - Assert.assertTrue("application finish time is not >= then start time", + Assert.assertTrue("application finish time is not >= than start time", (application.getFinishTime() >= application.getStartTime())); } @@ -364,6 +364,7 @@ private void sendAttemptUpdateSavedEvent(RMApp application) { application.getCurrentAppAttempt().handle( new RMAppAttemptEvent(application.getCurrentAppAttempt().getAppAttemptId(), RMAppAttemptEventType.ATTEMPT_UPDATE_SAVED)); + rmDispatcher.await(); } protected RMApp testCreateAppNewSaving(