From c24bc56484369404afae52fc2f3a23b75bfbbe75 Mon Sep 17 00:00:00 2001 From: Suresh Srinivas Date: Wed, 21 Nov 2012 05:55:48 +0000 Subject: [PATCH] HADOOP-9075. FileContext#FSLinkResolver should be made static. Contributed by Arpit Agarwal. git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1411988 13f79535-47bb-0310-9956-ffa450edef68 --- hadoop-common-project/hadoop-common/CHANGES.txt | 6 +++++- .../src/main/java/org/apache/hadoop/fs/FileContext.java | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index ddb0a712fa..023d87d6bd 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -132,7 +132,11 @@ Trunk (Unreleased) HADOOP-9004. Allow security unit tests to use external KDC. (Stephen Chu via suresh) - HADOOP-6616. Improve documentation for rack awareness. (Adam Faris via jghoman) + HADOOP-6616. Improve documentation for rack awareness. (Adam Faris via + jghoman) + + HADOOP-9075. FileContext#FSLinkResolver should be made static. + (Arpit Agarwal via suresh) BUG FIXES diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java index dc15b052cc..579c4e2749 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java @@ -1119,7 +1119,7 @@ public FileStatus next(final AbstractFileSystem fs, final Path p) * @param target The symlink's absolute target * @return Fully qualified version of the target. */ - private Path qualifySymlinkTarget(final AbstractFileSystem pathFS, + private static Path qualifySymlinkTarget(final AbstractFileSystem pathFS, Path pathWithLink, Path target) { // NB: makeQualified uses the target's scheme and authority, if // specified, and the scheme and authority of pathFS, if not. @@ -2321,7 +2321,7 @@ public Void next(final AbstractFileSystem fs, final Path p) * Class used to perform an operation on and resolve symlinks in a * path. The operation may potentially span multiple file systems. */ - protected abstract class FSLinkResolver { + protected static abstract class FSLinkResolver { // The maximum number of symbolic link components in a path private static final int MAX_PATH_LINKS = 32;