big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

YARN-8422. TestAMSimulator failing with NPE. Contributed by Giovanni Matteo Fumarola.

Browse Source
This commit is contained in:
Inigo Goiri 2018-06-12 10:59:50 -07:00
parent 6e756e8a62
commit c35481594f
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/appmaster/TestAMSimulator.java
View File

@ -49,8 +49,8 @@ public class TestAMSimulator {
private YarnConfiguration conf; private YarnConfiguration conf;
private Path metricOutputDir; private Path metricOutputDir;
private Class slsScheduler; private Class<?> slsScheduler;
private Class scheduler; private Class<?> scheduler;
@Parameterized.Parameters @Parameterized.Parameters
public static Collection<Object[]> params() { public static Collection<Object[]> params() {
@ -60,7 +60,7 @@ public static Collection<Object[]> params() {
}); });
} }
public TestAMSimulator(Class slsScheduler, Class scheduler) { public TestAMSimulator(Class<?> slsScheduler, Class<?> scheduler) {
this.slsScheduler = slsScheduler; this.slsScheduler = slsScheduler;
this.scheduler = scheduler; this.scheduler = scheduler;
} }
@ -115,7 +115,8 @@ private void verifySchedulerMetrics(String appId) {
} }
private void createMetricOutputDir() { private void createMetricOutputDir() {
Path testDir = Paths.get(System.getProperty("test.build.data")); Path testDir =
Paths.get(System.getProperty("test.build.data", "target/test-dir"));
try { try {
metricOutputDir = Files.createTempDirectory(testDir, "output"); metricOutputDir = Files.createTempDirectory(testDir, "output");
} catch (IOException e) { } catch (IOException e) {
@ -153,7 +154,9 @@ public void testAMSimulator() throws Exception {
@After @After
public void tearDown() { public void tearDown() {
rm.stop(); if (rm != null) {
rm.stop();
}
deleteMetricOutputDir(); deleteMetricOutputDir();
} }