big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDDS-420. putKey failing with KEY_ALLOCATION_ERROR. Contributed by Shashikant Banerjee.

Browse Source
This commit is contained in:
Mukul Kumar Singh 2018-09-13 11:29:31 +05:30
parent d7c0a08a1c
commit c6e19db197
5 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/StateContext.java
View File

@ -280,7 +280,7 @@ public void addPipelineActionIfAbsent(PipelineAction pipelineAction) {
&& pipelineActionIter.hasClosePipeline() && pipelineAction && pipelineActionIter.hasClosePipeline() && pipelineAction
.hasClosePipeline() .hasClosePipeline()
&& pipelineActionIter.getClosePipeline().getPipelineID() && pipelineActionIter.getClosePipeline().getPipelineID()
== pipelineAction.getClosePipeline().getPipelineID()) { .equals(pipelineAction.getClosePipeline().getPipelineID())) {
return; return;
} }
} }

3
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
View File

@ -397,6 +397,9 @@ private void handlePipelineFailure(RaftGroupId groupId,
.setAction(PipelineAction.Action.CLOSE) .setAction(PipelineAction.Action.CLOSE)
.build(); .build();
context.addPipelineActionIfAbsent(action); context.addPipelineActionIfAbsent(action);
LOG.debug(
"pipeline Action " + action.getAction() + " on pipeline " + pipelineID
+ ".Reason : " + action.getClosePipeline().getDetailedReason());
} }
void handleNodeSlowness( void handleNodeSlowness(

4
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/StaleNodeHandler.java
View File

@ -25,6 +25,8 @@
import org.apache.hadoop.hdds.scm.node.states.Node2ContainerMap; import org.apache.hadoop.hdds.scm.node.states.Node2ContainerMap;
import org.apache.hadoop.hdds.server.events.EventHandler; import org.apache.hadoop.hdds.server.events.EventHandler;
import org.apache.hadoop.hdds.server.events.EventPublisher; import org.apache.hadoop.hdds.server.events.EventPublisher;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import java.util.Set; import java.util.Set;
@ -32,6 +34,7 @@
* Handles Stale node event. * Handles Stale node event.
*/ */
public class StaleNodeHandler implements EventHandler<DatanodeDetails> { public class StaleNodeHandler implements EventHandler<DatanodeDetails> {
static final Logger LOG = LoggerFactory.getLogger(StaleNodeHandler.class);
private final Node2ContainerMap node2ContainerMap; private final Node2ContainerMap node2ContainerMap;
private final Mapping containerManager; private final Mapping containerManager;
@ -48,6 +51,7 @@ public void onMessage(DatanodeDetails datanodeDetails,
Set<PipelineID> pipelineIDs = Set<PipelineID> pipelineIDs =
containerManager.getPipelineOnDatanode(datanodeDetails); containerManager.getPipelineOnDatanode(datanodeDetails);
for (PipelineID id : pipelineIDs) { for (PipelineID id : pipelineIDs) {
LOG.info("closing pipeline {}.", id);
publisher.fireEvent(SCMEvents.PIPELINE_CLOSE, id); publisher.fireEvent(SCMEvents.PIPELINE_CLOSE, id);
} }
} }

2
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipelines/PipelineActionEventHandler.java
View File

@ -50,6 +50,8 @@ public void onMessage(PipelineActionsFromDatanode report,
case CLOSE: case CLOSE:
PipelineID pipelineID = PipelineID. PipelineID pipelineID = PipelineID.
getFromProtobuf(action.getClosePipeline().getPipelineID()); getFromProtobuf(action.getClosePipeline().getPipelineID());
LOG.info("Closing pipeline " + pipelineID + " for reason:" + action
.getClosePipeline().getDetailedReason());
publisher.fireEvent(SCMEvents.PIPELINE_CLOSE, pipelineID); publisher.fireEvent(SCMEvents.PIPELINE_CLOSE, pipelineID);
break; break;
default: default:

8
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipelines/ratis/RatisManagerImpl.java
View File

@ -110,15 +110,15 @@ public void initializePipeline(Pipeline pipeline) throws IOException {
* Close the pipeline. * Close the pipeline.
*/ */
public void closePipeline(Pipeline pipeline) throws IOException { public void closePipeline(Pipeline pipeline) throws IOException {
try (XceiverClientRatis client =
XceiverClientRatis.newXceiverClientRatis(pipeline, conf)) {
client.destroyPipeline();
}
super.closePipeline(pipeline); super.closePipeline(pipeline);
for (DatanodeDetails node : pipeline.getMachines()) { for (DatanodeDetails node : pipeline.getMachines()) {
// A node should always be the in ratis members list. // A node should always be the in ratis members list.
Preconditions.checkArgument(ratisMembers.remove(node)); Preconditions.checkArgument(ratisMembers.remove(node));
} }
try (XceiverClientRatis client =
XceiverClientRatis.newXceiverClientRatis(pipeline, conf)) {
client.destroyPipeline();
}
} }
/** /**