big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MAPREDUCE-2985. Fixed findbugs warnings in ResourceLocalizationService. Contributed by Thomas Graves.

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1169955 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Arun Murthy 2011-09-12 21:53:51 +00:00
parent 8332126c52
commit c8383a5f49
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-mapreduce-project/CHANGES.txt
View File

@ -1296,6 +1296,9 @@ Release 0.23.0 - Unreleased
MAPREDUCE-2979. Removed the needless ClientProtocolProvider configuration MAPREDUCE-2979. Removed the needless ClientProtocolProvider configuration
from the hadoop-mapreduce-client-core module. (Siddharth Seth via vinodkv) from the hadoop-mapreduce-client-core module. (Siddharth Seth via vinodkv)
MAPREDUCE-2985. Fixed findbugs warnings in ResourceLocalizationService.
(Thomas Graves via acmurthy)
Release 0.22.0 - Unreleased Release 0.22.0 - Unreleased
INCOMPATIBLE CHANGES INCOMPATIBLE CHANGES

16
hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
View File

@ -289,11 +289,12 @@ public void handle(LocalizationEvent event) {
LocalizerContext ctxt = new LocalizerContext( LocalizerContext ctxt = new LocalizerContext(
c.getUser(), c.getContainerID(), c.getCredentials()); c.getUser(), c.getContainerID(), c.getCredentials());
rsrcs = rsrcReqs.getRequestedResources(); rsrcs = rsrcReqs.getRequestedResources();
for (LocalResourceVisibility vis : rsrcs.keySet()) { for (Map.Entry<LocalResourceVisibility, Collection<LocalResourceRequest>> e :
tracker = getLocalResourcesTracker(vis, c.getUser(), rsrcs.entrySet()) {
tracker = getLocalResourcesTracker(e.getKey(), c.getUser(),
c.getContainerID().getAppId()); c.getContainerID().getAppId());
for (LocalResourceRequest req : rsrcs.get(vis)) { for (LocalResourceRequest req : e.getValue()) {
tracker.handle(new ResourceRequestEvent(req, vis, ctxt)); tracker.handle(new ResourceRequestEvent(req, e.getKey(), ctxt));
} }
} }
break; break;
@ -312,10 +313,11 @@ public void handle(LocalizationEvent event) {
(ContainerLocalizationCleanupEvent) event; (ContainerLocalizationCleanupEvent) event;
c = rsrcCleanup.getContainer(); c = rsrcCleanup.getContainer();
rsrcs = rsrcCleanup.getResources(); rsrcs = rsrcCleanup.getResources();
for (LocalResourceVisibility vis : rsrcs.keySet()) { for (Map.Entry<LocalResourceVisibility, Collection<LocalResourceRequest>> e :
tracker = getLocalResourcesTracker(vis, c.getUser(), rsrcs.entrySet()) {
tracker = getLocalResourcesTracker(e.getKey(), c.getUser(),
c.getContainerID().getAppId()); c.getContainerID().getAppId());
for (LocalResourceRequest req : rsrcs.get(vis)) { for (LocalResourceRequest req : e.getValue()) {
tracker.handle(new ResourceReleaseEvent(req, c.getContainerID())); tracker.handle(new ResourceReleaseEvent(req, c.getContainerID()));
} }
} }