big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-16350. Datanode start time should be set after RPC server starts successfully (#3711)

Browse Source
This commit is contained in:
Viraj Jasani 2021-11-25 07:53:04 +05:30 committed by GitHub
parent 99b161dec7
commit cdc13e91b6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
View File

@ -412,7 +412,7 @@ private static Tracer createTracer(Configuration conf) {
private ScheduledThreadPoolExecutor metricsLoggerTimer; private ScheduledThreadPoolExecutor metricsLoggerTimer;
private final long startTime = now(); private long startTime = 0;
/** /**
* Creates a dummy DataNode for testing purpose. * Creates a dummy DataNode for testing purpose.
@ -2721,6 +2721,7 @@ public void runDatanodeDaemon() throws IOException {
} }
ipcServer.setTracer(tracer); ipcServer.setTracer(tracer);
ipcServer.start(); ipcServer.start();
startTime = now();
startPlugins(getConf()); startPlugins(getConf());
} }

1
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java
View File

@ -77,6 +77,7 @@ public void testDataNodeMXBean() throws Exception {
Assert.assertEquals(datanode.getVersion(),version); Assert.assertEquals(datanode.getVersion(),version);
// get attribute "DNStartedTimeInMillis" // get attribute "DNStartedTimeInMillis"
long startTime = (long) mbs.getAttribute(mxbeanName, "DNStartedTimeInMillis"); long startTime = (long) mbs.getAttribute(mxbeanName, "DNStartedTimeInMillis");
Assert.assertTrue("Datanode start time should not be 0", startTime > 0);
Assert.assertEquals(datanode.getDNStartedTimeInMillis(), startTime); Assert.assertEquals(datanode.getDNStartedTimeInMillis(), startTime);
// get attribute "SotfwareVersion" // get attribute "SotfwareVersion"
String softwareVersion = String softwareVersion =