From d162252d7a7223631ff66ba0210953296407e55f Mon Sep 17 00:00:00 2001 From: Xiao Chen Date: Thu, 23 Nov 2017 09:00:59 -0800 Subject: [PATCH] HADOOP-15067. GC time percentage reported in JvmMetrics should be a gauge, not counter. Contributed by Misha Dmitriev. --- .../main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java | 2 +- .../java/org/apache/hadoop/metrics2/source/TestJvmMetrics.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java index 8c3375f13f..5f9afddc57 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java @@ -188,7 +188,7 @@ public class JvmMetrics implements MetricsSource { } if (gcTimeMonitor != null) { - rb.addCounter(GcTimePercentage, + rb.addGauge(GcTimePercentage, gcTimeMonitor.getLatestGcData().getGcTimePercentage()); } } diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/source/TestJvmMetrics.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/source/TestJvmMetrics.java index 5320b6e3ee..aa1b009692 100644 --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/source/TestJvmMetrics.java +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/source/TestJvmMetrics.java @@ -101,7 +101,7 @@ public class TestJvmMetrics { verify(rb).tag(SessionId, "test"); for (JvmMetricsInfo info : JvmMetricsInfo.values()) { if (info.name().equals("GcTimePercentage")) { - verify(rb).addCounter(eq(info), anyInt()); + verify(rb).addGauge(eq(info), anyInt()); } } }