big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

YARN-9790. Failed to set default-application-lifetime if maximum-application-lifetime is less than or equal to zero. Contributed by kyungwan nam.

Browse Source
This commit is contained in:
Abhishek Modi 2019-09-01 09:54:46 +05:30
parent c187d2cb9f
commit d2d963f3d4
3 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java
View File

@ -3116,7 +3116,8 @@ public long checkAndGetApplicationLifetime(String queueName,
// check only for maximum, that's enough because default can't // check only for maximum, that's enough because default can't
// exceed maximum // exceed maximum
if (maximumApplicationLifetime <= 0) { if (maximumApplicationLifetime <= 0) {
return lifetimeRequestedByApp; return (lifetimeRequestedByApp <= 0) ? defaultApplicationLifetime :
lifetimeRequestedByApp;
} }
if (lifetimeRequestedByApp <= 0) { if (lifetimeRequestedByApp <= 0) {

3
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
View File

@ -259,7 +259,8 @@ protected void setupQueueConfigs(Resource clusterResource,
conf.getMaximumLifetimePerQueue((getQueuePath())); conf.getMaximumLifetimePerQueue((getQueuePath()));
defaultApplicationLifetime = defaultApplicationLifetime =
conf.getDefaultLifetimePerQueue((getQueuePath())); conf.getDefaultLifetimePerQueue((getQueuePath()));
if (defaultApplicationLifetime > maxApplicationLifetime) { if (maxApplicationLifetime > 0 &&
defaultApplicationLifetime > maxApplicationLifetime) {
throw new YarnRuntimeException( throw new YarnRuntimeException(
"Default lifetime" + defaultApplicationLifetime "Default lifetime" + defaultApplicationLifetime
+ " can't exceed maximum lifetime " + maxApplicationLifetime); + " can't exceed maximum lifetime " + maxApplicationLifetime);

19
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java
View File

@ -5171,7 +5171,8 @@ public void testcheckAndGetApplicationLifetime() throws Exception {
Assert.assertEquals(100, cs.checkAndGetApplicationLifetime("default", 100)); Assert.assertEquals(100, cs.checkAndGetApplicationLifetime("default", 100));
Assert.assertEquals(defaultLifetime, Assert.assertEquals(defaultLifetime,
cs.checkAndGetApplicationLifetime("default", -1)); cs.checkAndGetApplicationLifetime("default", -1));
Assert.assertEquals(0, cs.checkAndGetApplicationLifetime("default", 0)); Assert.assertEquals(defaultLifetime,
cs.checkAndGetApplicationLifetime("default", 0));
Assert.assertEquals(maxLifetime, Assert.assertEquals(maxLifetime,
cs.getMaximumApplicationLifetime("default")); cs.getMaximumApplicationLifetime("default"));
@ -5191,8 +5192,10 @@ public void testcheckAndGetApplicationLifetime() throws Exception {
defaultLifetime = 0; defaultLifetime = 0;
cs = setUpCSQueue(maxLifetime, defaultLifetime); cs = setUpCSQueue(maxLifetime, defaultLifetime);
Assert.assertEquals(100, cs.checkAndGetApplicationLifetime("default", 100)); Assert.assertEquals(100, cs.checkAndGetApplicationLifetime("default", 100));
Assert.assertEquals(-1, cs.checkAndGetApplicationLifetime("default", -1)); Assert.assertEquals(defaultLifetime,
Assert.assertEquals(0, cs.checkAndGetApplicationLifetime("default", 0)); cs.checkAndGetApplicationLifetime("default", -1));
Assert.assertEquals(defaultLifetime,
cs.checkAndGetApplicationLifetime("default", 0));
maxLifetime = 10; maxLifetime = 10;
defaultLifetime = -1; defaultLifetime = -1;
@ -5213,6 +5216,16 @@ public void testcheckAndGetApplicationLifetime() throws Exception {
Assert.assertTrue( Assert.assertTrue(
ye.getMessage().contains("can't exceed maximum lifetime")); ye.getMessage().contains("can't exceed maximum lifetime"));
} }
maxLifetime = -1;
defaultLifetime = 10;
cs = setUpCSQueue(maxLifetime, defaultLifetime);
Assert.assertEquals(100,
cs.checkAndGetApplicationLifetime("default", 100));
Assert.assertEquals(defaultLifetime,
cs.checkAndGetApplicationLifetime("default", -1));
Assert.assertEquals(defaultLifetime,
cs.checkAndGetApplicationLifetime("default", 0));
} }
private CapacityScheduler setUpCSQueue(long maxLifetime, private CapacityScheduler setUpCSQueue(long maxLifetime,