big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HADOOP-19061 Capture exception from rpcRequestSender.start() in IPC.Connection.run() (#6519)

Browse Source 
* HADOOP-19061 - Capture exception from rpcRequestSender.start() in IPC.Connection.run() and proper cleaning is followed if an exception is thrown.

---------

Co-authored-by: Xing Lin <xinglin@linkedin.com>
This commit is contained in:
Xing Lin 2024-02-02 16:22:16 -08:00 committed by GitHub
parent d278b349f6
commit d74e5160cd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 15 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
View File

@ -1081,15 +1081,15 @@ private synchronized void sendPing() throws IOException {
@Override
public void run() {
try {
// Don't start the ipc parameter sending thread until we start this
// thread, because the shutdown logic only gets triggered if this
// thread is started.
rpcRequestThread.start();
if (LOG.isDebugEnabled())
LOG.debug(getName() + ": starting, having connections "
+ connections.size());
if (LOG.isDebugEnabled()) {
LOG.debug(getName() + ": starting, having connections " + connections.size());
}
try {
while (waitForWork()) {//wait here for work - read or close connection
receiveRpcResponse();
}
@ -1097,16 +1097,18 @@ public void run() {
// This truly is unexpected, since we catch IOException in receiveResponse
// -- this is only to be really sure that we don't leave a client hanging
// forever.
LOG.warn("Unexpected error reading responses on connection " + this, t);
markClosed(new IOException("Error reading responses", t));
String msg = String.format("Unexpected error on connection %s. Closing it.", this);
LOG.warn(msg, t);
markClosed(new IOException(msg, t));
}
close();
if (LOG.isDebugEnabled())
if (LOG.isDebugEnabled()) {
LOG.debug(getName() + ": stopped, remaining connections "
+ connections.size());
}
}
/**
* A thread to write rpc requests to the socket.