From d9911e923d3e6d90bc7e54fcc284161496d3b521 Mon Sep 17 00:00:00 2001 From: Harsh J Date: Fri, 13 Jul 2012 07:20:27 +0000 Subject: [PATCH] HDFS-3612. Single namenode image directory config warning can be improved. Contributed by Andy Isaacson. (harsh) git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1361059 13f79535-47bb-0310-9956-ffa450edef68 --- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 3 +++ .../hadoop/hdfs/server/namenode/FSNamesystem.java | 10 ++++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index 804a8a6314..4a86a202f7 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -316,6 +316,9 @@ Branch-2 ( Unreleased changes ) HDFS-3306. fuse_dfs: don't lock release operations. (Colin Patrick McCabe via eli) + HDFS-3612. Single namenode image directory config warning can + be improved. (Andy Isaacson via harsh) + OPTIMIZATIONS HDFS-2982. Startup performance suffers when there are many edit log diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java index 5e775d952b..1f65e27428 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java @@ -393,12 +393,14 @@ public static FSNamesystem loadFromDisk(Configuration conf, throws IOException { if (namespaceDirs.size() == 1) { - LOG.warn("Only one " + DFS_NAMENODE_NAME_DIR_KEY - + " directory configured , beware data loss!"); + LOG.warn("Only one image storage directory (" + + DFS_NAMENODE_NAME_DIR_KEY + ") configured. Beware of dataloss" + + " due to lack of redundant storage directories!"); } if (namespaceEditsDirs.size() == 1) { - LOG.warn("Only one " + DFS_NAMENODE_EDITS_DIR_KEY - + " directory configured , beware data loss!"); + LOG.warn("Only one namespace edits storage directory (" + + DFS_NAMENODE_EDITS_DIR_KEY + ") configured. Beware of dataloss" + + " due to lack of redundant storage directories!"); } FSImage fsImage = new FSImage(conf, namespaceDirs, namespaceEditsDirs);