HADOOP-12829. StatisticsDataReferenceCleaner swallows interrupt exceptions (Gregory Chanan via cmccabe)

This commit is contained in:
Colin Patrick Mccabe 2016-02-23 11:11:22 -08:00
parent 9ed17f181d
commit d9c409a428
2 changed files with 8 additions and 4 deletions

View File

@ -719,6 +719,9 @@ Release 2.9.0 - UNRELEASED
HADOOP-12714. Fix hadoop-mapreduce-client-nativetask unit test which fails
because it is not able to open the "glibc bug spill" file. (cmccabe)
HADOOP-12829. StatisticsDataReferenceCleaner swallows interrupt exceptions
(Gregory Chanan via cmccabe)
Release 2.8.0 - UNRELEASED
INCOMPATIBLE CHANGES

View File

@ -3184,15 +3184,16 @@ public void cleanUp() {
private static class StatisticsDataReferenceCleaner implements Runnable {
@Override
public void run() {
while (true) {
while (!Thread.interrupted()) {
try {
StatisticsDataReference ref =
(StatisticsDataReference)STATS_DATA_REF_QUEUE.remove();
ref.cleanUp();
} catch (InterruptedException ie) {
LOG.warn("Cleaner thread interrupted, will stop", ie);
Thread.currentThread().interrupt();
} catch (Throwable th) {
// the cleaner thread should continue to run even if there are
// exceptions, including InterruptedException
LOG.warn("exception in the cleaner thread but it will continue to "
LOG.warn("Exception in the cleaner thread but it will continue to "
+ "run", th);
}
}