big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HADOOP-16717. Remove GenericsUtil isLog4jLogger dependency on Log4jLoggerAdapter. Contributed by Xieming Li.

Browse Source
This commit is contained in:
Akira Ajisaka 2019-11-25 14:36:27 +09:00
parent 049940e77b
commit da9435182a
No known key found for this signature in database
GPG Key ID: C1EDBB9CA400FD50
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericsUtil.java
View File

@ -25,7 +25,6 @@
import org.apache.hadoop.classification.InterfaceStability; import org.apache.hadoop.classification.InterfaceStability;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
import org.slf4j.impl.Log4jLoggerAdapter;
/** /**
* Contains utility methods for dealing with Java Generics. * Contains utility methods for dealing with Java Generics.
@ -85,6 +84,11 @@ public static boolean isLog4jLogger(Class<?> clazz) {
return false; return false;
} }
Logger log = LoggerFactory.getLogger(clazz); Logger log = LoggerFactory.getLogger(clazz);
return log instanceof Log4jLoggerAdapter; try {
Class log4jClass = Class.forName("org.slf4j.impl.Log4jLoggerAdapter");
return log4jClass.isInstance(log);
} catch (ClassNotFoundException e) {
return false;
}
} }
} }