big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

YARN-3457. NPE when NodeManager.serviceInit fails and stopRecoveryStore called. Contributed by Bibin A Chundatt.

Browse Source
This commit is contained in:
Tsuyoshi Ozawa 2015-04-08 15:56:18 +09:00
parent ab04ff9efe
commit dd852f5b8c
2 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-yarn-project/CHANGES.txt
View File

@ -153,6 +153,9 @@ Release 2.8.0 - UNRELEASED
YARN-3110. Few issues in ApplicationHistory web ui. (Naganarasimha G R via xgong) YARN-3110. Few issues in ApplicationHistory web ui. (Naganarasimha G R via xgong)
YARN-3457. NPE when NodeManager.serviceInit fails and stopRecoveryStore called.
(Bibin A Chundatt via ozawa)
Release 2.7.0 - UNRELEASED Release 2.7.0 - UNRELEASED
INCOMPATIBLE CHANGES INCOMPATIBLE CHANGES

22
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java
View File

@ -177,16 +177,18 @@ private void initAndStartRecoveryStore(Configuration conf)
private void stopRecoveryStore() throws IOException { private void stopRecoveryStore() throws IOException {
nmStore.stop(); nmStore.stop();
if (context.getDecommissioned() && nmStore.canRecover()) { if (null != context) {
LOG.info("Removing state store due to decommission"); if (context.getDecommissioned() && nmStore.canRecover()) {
Configuration conf = getConfig(); LOG.info("Removing state store due to decommission");
Path recoveryRoot = new Path( Configuration conf = getConfig();
conf.get(YarnConfiguration.NM_RECOVERY_DIR)); Path recoveryRoot =
LOG.info("Removing state store at " + recoveryRoot new Path(conf.get(YarnConfiguration.NM_RECOVERY_DIR));
+ " due to decommission"); LOG.info("Removing state store at " + recoveryRoot
FileSystem recoveryFs = FileSystem.getLocal(conf); + " due to decommission");
if (!recoveryFs.delete(recoveryRoot, true)) { FileSystem recoveryFs = FileSystem.getLocal(conf);
LOG.warn("Unable to delete " + recoveryRoot); if (!recoveryFs.delete(recoveryRoot, true)) {
LOG.warn("Unable to delete " + recoveryRoot);
}
} }
} }
} }