MAPREDUCE-4323. NM leaks filesystems (Jason Lowe via jeagles)
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1375164 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Jonathan Turner Eagles
parent
ea7af8f76e
commit
df5e2b8352
@ -51,3 +51,5 @@ Release 0.23.3 - Unreleased
|
||||
|
||||
YARN-27. Failed refreshQueues due to misconfiguration prevents further
|
||||
refreshing of queues (Arun Murthy via tgraves)
|
||||
|
||||
MAPREDUCE-4323. NM leaks filesystems (Jason Lowe via jeagles)
|
||||
|
||||
@ -43,6 +43,7 @@
|
||||
import org.apache.commons.logging.LogFactory;
|
||||
import org.apache.hadoop.conf.Configuration;
|
||||
import org.apache.hadoop.fs.FileContext;
|
||||
import org.apache.hadoop.fs.FileSystem;
|
||||
import org.apache.hadoop.fs.FileUtil;
|
||||
import org.apache.hadoop.fs.LocalDirAllocator;
|
||||
import org.apache.hadoop.fs.Path;
|
||||
@ -176,10 +177,14 @@ public LocalizationProtocol run() {
|
||||
e.printStackTrace(System.out);
|
||||
return -1;
|
||||
} finally {
|
||||
if (exec != null) {
|
||||
exec.shutdownNow();
|
||||
try {
|
||||
if (exec != null) {
|
||||
exec.shutdownNow();
|
||||
}
|
||||
LocalDirAllocator.removeContext(appCacheDirContextName);
|
||||
} finally {
|
||||
closeFileSystems(ugi);
|
||||
}
|
||||
LocalDirAllocator.removeContext(appCacheDirContextName);
|
||||
}
|
||||
}
|
||||
|
||||
@ -215,7 +220,15 @@ void sleep(int duration) throws InterruptedException {
|
||||
TimeUnit.SECONDS.sleep(duration);
|
||||
}
|
||||
|
||||
private void localizeFiles(LocalizationProtocol nodemanager,
|
||||
protected void closeFileSystems(UserGroupInformation ugi) {
|
||||
try {
|
||||
FileSystem.closeAllForUGI(ugi);
|
||||
} catch (IOException e) {
|
||||
LOG.warn("Failed to close filesystems: ", e);
|
||||
}
|
||||
}
|
||||
|
||||
protected void localizeFiles(LocalizationProtocol nodemanager,
|
||||
CompletionService<Path> cs, UserGroupInformation ugi)
|
||||
throws IOException {
|
||||
while (true) {
|
||||
|
||||
@ -59,7 +59,6 @@
|
||||
import org.apache.hadoop.yarn.server.nodemanager.containermanager.loghandler.event.LogHandlerEvent;
|
||||
import org.apache.hadoop.yarn.service.AbstractService;
|
||||
|
||||
import com.google.common.annotations.VisibleForTesting;
|
||||
import com.google.common.util.concurrent.ThreadFactoryBuilder;
|
||||
|
||||
public class LogAggregationService extends AbstractService implements
|
||||
@ -203,7 +202,7 @@ private void createDir(FileSystem fs, Path path, FsPermission fsPerm)
|
||||
fs.setPermission(path, new FsPermission(fsPerm));
|
||||
}
|
||||
|
||||
private void createAppDir(final String user, final ApplicationId appId,
|
||||
protected void createAppDir(final String user, final ApplicationId appId,
|
||||
UserGroupInformation userUgi) {
|
||||
try {
|
||||
userUgi.doAs(new PrivilegedExceptionAction<Object>() {
|
||||
@ -286,13 +285,12 @@ private void initApp(final ApplicationId appId, String user,
|
||||
this.dispatcher.getEventHandler().handle(eventResponse);
|
||||
}
|
||||
|
||||
@VisibleForTesting
|
||||
public void initAppAggregator(final ApplicationId appId, String user,
|
||||
protected void initAppAggregator(final ApplicationId appId, String user,
|
||||
Credentials credentials, ContainerLogsRetentionPolicy logRetentionPolicy,
|
||||
Map<ApplicationAccessType, String> appAcls) {
|
||||
|
||||
// Get user's FileSystem credentials
|
||||
UserGroupInformation userUgi =
|
||||
final UserGroupInformation userUgi =
|
||||
UserGroupInformation.createRemoteUser(user);
|
||||
if (credentials != null) {
|
||||
for (Token<? extends TokenIdentifier> token : credentials
|
||||
@ -301,9 +299,6 @@ public void initAppAggregator(final ApplicationId appId, String user,
|
||||
}
|
||||
}
|
||||
|
||||
// Create the app dir
|
||||
createAppDir(user, appId, userUgi);
|
||||
|
||||
// New application
|
||||
final AppLogAggregator appLogAggregator =
|
||||
new AppLogAggregatorImpl(this.dispatcher, this.deletionService,
|
||||
@ -313,6 +308,14 @@ public void initAppAggregator(final ApplicationId appId, String user,
|
||||
if (this.appLogAggregators.putIfAbsent(appId, appLogAggregator) != null) {
|
||||
throw new YarnException("Duplicate initApp for " + appId);
|
||||
}
|
||||
// wait until check for existing aggregator to create dirs
|
||||
try {
|
||||
// Create the app dir
|
||||
createAppDir(user, appId, userUgi);
|
||||
} catch (YarnException e) {
|
||||
closeFileSystems(userUgi);
|
||||
throw e;
|
||||
}
|
||||
|
||||
|
||||
// TODO Get the user configuration for the list of containers that need log
|
||||
@ -325,12 +328,21 @@ public void run() {
|
||||
appLogAggregator.run();
|
||||
} finally {
|
||||
appLogAggregators.remove(appId);
|
||||
closeFileSystems(userUgi);
|
||||
}
|
||||
}
|
||||
};
|
||||
this.threadPool.execute(aggregatorWrapper);
|
||||
}
|
||||
|
||||
protected void closeFileSystems(final UserGroupInformation userUgi) {
|
||||
try {
|
||||
FileSystem.closeAllForUGI(userUgi);
|
||||
} catch (IOException e) {
|
||||
LOG.warn("Failed to close filesystems: ", e);
|
||||
}
|
||||
}
|
||||
|
||||
// for testing only
|
||||
@Private
|
||||
int getNumAggregators() {
|
||||
|
||||
@ -19,6 +19,7 @@
|
||||
|
||||
import static org.junit.Assert.assertEquals;
|
||||
import static org.junit.Assert.fail;
|
||||
import static org.mockito.Matchers.any;
|
||||
import static org.mockito.Matchers.anyBoolean;
|
||||
import static org.mockito.Matchers.anyInt;
|
||||
import static org.mockito.Matchers.argThat;
|
||||
@ -27,6 +28,7 @@
|
||||
import static org.mockito.Matchers.same;
|
||||
import static org.mockito.Mockito.doNothing;
|
||||
import static org.mockito.Mockito.doReturn;
|
||||
import static org.mockito.Mockito.doThrow;
|
||||
import static org.mockito.Mockito.mock;
|
||||
import static org.mockito.Mockito.never;
|
||||
import static org.mockito.Mockito.spy;
|
||||
@ -57,6 +59,7 @@
|
||||
import org.apache.hadoop.security.Credentials;
|
||||
import org.apache.hadoop.security.UserGroupInformation;
|
||||
import org.apache.hadoop.security.token.Token;
|
||||
import org.apache.hadoop.yarn.YarnException;
|
||||
import org.apache.hadoop.yarn.api.records.LocalResource;
|
||||
import org.apache.hadoop.yarn.api.records.LocalResourceType;
|
||||
import org.apache.hadoop.yarn.api.records.LocalResourceVisibility;
|
||||
@ -76,47 +79,28 @@ public class TestContainerLocalizer {
|
||||
static final Path basedir =
|
||||
new Path("target", TestContainerLocalizer.class.getName());
|
||||
|
||||
@Test
|
||||
@SuppressWarnings("unchecked") // mocked generics
|
||||
public void testContainerLocalizerMain() throws Exception {
|
||||
Configuration conf = new Configuration();
|
||||
AbstractFileSystem spylfs =
|
||||
spy(FileContext.getLocalFSFileContext().getDefaultFileSystem());
|
||||
// don't actually create dirs
|
||||
doNothing().when(spylfs).mkdir(
|
||||
isA(Path.class), isA(FsPermission.class), anyBoolean());
|
||||
FileContext lfs = FileContext.getFileContext(spylfs, conf);
|
||||
final String user = "yak";
|
||||
final String appId = "app_RM_0";
|
||||
final String cId = "container_0";
|
||||
final InetSocketAddress nmAddr = new InetSocketAddress("foobar", 8040);
|
||||
final List<Path> localDirs = new ArrayList<Path>();
|
||||
for (int i = 0; i < 4; ++i) {
|
||||
localDirs.add(lfs.makeQualified(new Path(basedir, i + "")));
|
||||
}
|
||||
RecordFactory mockRF = getMockLocalizerRecordFactory();
|
||||
ContainerLocalizer concreteLoc = new ContainerLocalizer(lfs, user,
|
||||
appId, cId, localDirs, mockRF);
|
||||
ContainerLocalizer localizer = spy(concreteLoc);
|
||||
static final String appUser = "yak";
|
||||
static final String appId = "app_RM_0";
|
||||
static final String containerId = "container_0";
|
||||
static final InetSocketAddress nmAddr =
|
||||
new InetSocketAddress("foobar", 8040);
|
||||
|
||||
// return credential stream instead of opening local file
|
||||
final Random r = new Random();
|
||||
long seed = r.nextLong();
|
||||
r.setSeed(seed);
|
||||
System.out.println("SEED: " + seed);
|
||||
DataInputBuffer appTokens = createFakeCredentials(r, 10);
|
||||
Path tokenPath =
|
||||
lfs.makeQualified(new Path(
|
||||
String.format(ContainerLocalizer.TOKEN_FILE_NAME_FMT, cId)));
|
||||
doReturn(new FSDataInputStream(new FakeFSDataInputStream(appTokens))
|
||||
).when(spylfs).open(tokenPath);
|
||||
private AbstractFileSystem spylfs;
|
||||
private Random random;
|
||||
private List<Path> localDirs;
|
||||
private Path tokenPath;
|
||||
private LocalizationProtocol nmProxy;
|
||||
|
||||
@Test
|
||||
public void testContainerLocalizerMain() throws Exception {
|
||||
ContainerLocalizer localizer = setupContainerLocalizerForTest();
|
||||
|
||||
// mock heartbeat responses from NM
|
||||
LocalizationProtocol nmProxy = mock(LocalizationProtocol.class);
|
||||
LocalResource rsrcA = getMockRsrc(r, LocalResourceVisibility.PRIVATE);
|
||||
LocalResource rsrcB = getMockRsrc(r, LocalResourceVisibility.PRIVATE);
|
||||
LocalResource rsrcC = getMockRsrc(r, LocalResourceVisibility.APPLICATION);
|
||||
LocalResource rsrcD = getMockRsrc(r, LocalResourceVisibility.PRIVATE);
|
||||
LocalResource rsrcA = getMockRsrc(random, LocalResourceVisibility.PRIVATE);
|
||||
LocalResource rsrcB = getMockRsrc(random, LocalResourceVisibility.PRIVATE);
|
||||
LocalResource rsrcC = getMockRsrc(random,
|
||||
LocalResourceVisibility.APPLICATION);
|
||||
LocalResource rsrcD = getMockRsrc(random, LocalResourceVisibility.PRIVATE);
|
||||
when(nmProxy.heartbeat(isA(LocalizerStatus.class)))
|
||||
.thenReturn(new MockLocalizerHeartbeatResponse(LocalizerAction.LIVE,
|
||||
Collections.singletonList(rsrcA)))
|
||||
@ -130,6 +114,7 @@ public void testContainerLocalizerMain() throws Exception {
|
||||
Collections.<LocalResource>emptyList()))
|
||||
.thenReturn(new MockLocalizerHeartbeatResponse(LocalizerAction.DIE,
|
||||
null));
|
||||
|
||||
doReturn(new FakeDownload(rsrcA.getResource().getFile(), true)).when(
|
||||
localizer).download(isA(LocalDirAllocator.class), eq(rsrcA),
|
||||
isA(UserGroupInformation.class));
|
||||
@ -142,33 +127,13 @@ public void testContainerLocalizerMain() throws Exception {
|
||||
doReturn(new FakeDownload(rsrcD.getResource().getFile(), true)).when(
|
||||
localizer).download(isA(LocalDirAllocator.class), eq(rsrcD),
|
||||
isA(UserGroupInformation.class));
|
||||
doReturn(nmProxy).when(localizer).getProxy(nmAddr);
|
||||
doNothing().when(localizer).sleep(anyInt());
|
||||
|
||||
// return result instantly for deterministic test
|
||||
ExecutorService syncExec = mock(ExecutorService.class);
|
||||
CompletionService<Path> cs = mock(CompletionService.class);
|
||||
when(cs.submit(isA(Callable.class)))
|
||||
.thenAnswer(new Answer<Future<Path>>() {
|
||||
@Override
|
||||
public Future<Path> answer(InvocationOnMock invoc)
|
||||
throws Throwable {
|
||||
Future<Path> done = mock(Future.class);
|
||||
when(done.isDone()).thenReturn(true);
|
||||
FakeDownload d = (FakeDownload) invoc.getArguments()[0];
|
||||
when(done.get()).thenReturn(d.call());
|
||||
return done;
|
||||
}
|
||||
});
|
||||
doReturn(syncExec).when(localizer).createDownloadThreadPool();
|
||||
doReturn(cs).when(localizer).createCompletionService(syncExec);
|
||||
|
||||
// run localization
|
||||
assertEquals(0, localizer.runLocalization(nmAddr));
|
||||
|
||||
// verify created cache
|
||||
for (Path p : localDirs) {
|
||||
Path base = new Path(new Path(p, ContainerLocalizer.USERCACHE), user);
|
||||
Path base = new Path(new Path(p, ContainerLocalizer.USERCACHE), appUser);
|
||||
Path privcache = new Path(base, ContainerLocalizer.FILECACHE);
|
||||
// $x/usercache/$user/filecache
|
||||
verify(spylfs).mkdir(eq(privcache), isA(FsPermission.class), eq(false));
|
||||
@ -194,11 +159,91 @@ public Future<Path> answer(InvocationOnMock invoc)
|
||||
@Override
|
||||
public boolean matches(Object o) {
|
||||
LocalizerStatus status = (LocalizerStatus) o;
|
||||
return !cId.equals(status.getLocalizerId());
|
||||
return !containerId.equals(status.getLocalizerId());
|
||||
}
|
||||
}));
|
||||
}
|
||||
|
||||
@Test
|
||||
@SuppressWarnings("unchecked") // mocked generics
|
||||
public void testContainerLocalizerClosesFilesystems() throws Exception {
|
||||
// verify filesystems are closed when localizer doesn't fail
|
||||
ContainerLocalizer localizer = setupContainerLocalizerForTest();
|
||||
doNothing().when(localizer).localizeFiles(any(LocalizationProtocol.class),
|
||||
any(CompletionService.class), any(UserGroupInformation.class));
|
||||
verify(localizer, never()).closeFileSystems(
|
||||
any(UserGroupInformation.class));
|
||||
localizer.runLocalization(nmAddr);
|
||||
verify(localizer).closeFileSystems(any(UserGroupInformation.class));
|
||||
|
||||
// verify filesystems are closed when localizer fails
|
||||
localizer = setupContainerLocalizerForTest();
|
||||
doThrow(new YarnException("Forced Failure")).when(localizer).localizeFiles(
|
||||
any(LocalizationProtocol.class), any(CompletionService.class),
|
||||
any(UserGroupInformation.class));
|
||||
verify(localizer, never()).closeFileSystems(
|
||||
any(UserGroupInformation.class));
|
||||
localizer.runLocalization(nmAddr);
|
||||
verify(localizer).closeFileSystems(any(UserGroupInformation.class));
|
||||
}
|
||||
|
||||
@SuppressWarnings("unchecked") // mocked generics
|
||||
private ContainerLocalizer setupContainerLocalizerForTest()
|
||||
throws Exception {
|
||||
spylfs = spy(FileContext.getLocalFSFileContext().getDefaultFileSystem());
|
||||
// don't actually create dirs
|
||||
doNothing().when(spylfs).mkdir(
|
||||
isA(Path.class), isA(FsPermission.class), anyBoolean());
|
||||
|
||||
Configuration conf = new Configuration();
|
||||
FileContext lfs = FileContext.getFileContext(spylfs, conf);
|
||||
localDirs = new ArrayList<Path>();
|
||||
for (int i = 0; i < 4; ++i) {
|
||||
localDirs.add(lfs.makeQualified(new Path(basedir, i + "")));
|
||||
}
|
||||
RecordFactory mockRF = getMockLocalizerRecordFactory();
|
||||
ContainerLocalizer concreteLoc = new ContainerLocalizer(lfs, appUser,
|
||||
appId, containerId, localDirs, mockRF);
|
||||
ContainerLocalizer localizer = spy(concreteLoc);
|
||||
|
||||
// return credential stream instead of opening local file
|
||||
random = new Random();
|
||||
long seed = random.nextLong();
|
||||
System.out.println("SEED: " + seed);
|
||||
random.setSeed(seed);
|
||||
DataInputBuffer appTokens = createFakeCredentials(random, 10);
|
||||
tokenPath =
|
||||
lfs.makeQualified(new Path(
|
||||
String.format(ContainerLocalizer.TOKEN_FILE_NAME_FMT,
|
||||
containerId)));
|
||||
doReturn(new FSDataInputStream(new FakeFSDataInputStream(appTokens))
|
||||
).when(spylfs).open(tokenPath);
|
||||
|
||||
nmProxy = mock(LocalizationProtocol.class);
|
||||
doReturn(nmProxy).when(localizer).getProxy(nmAddr);
|
||||
doNothing().when(localizer).sleep(anyInt());
|
||||
|
||||
// return result instantly for deterministic test
|
||||
ExecutorService syncExec = mock(ExecutorService.class);
|
||||
CompletionService<Path> cs = mock(CompletionService.class);
|
||||
when(cs.submit(isA(Callable.class)))
|
||||
.thenAnswer(new Answer<Future<Path>>() {
|
||||
@Override
|
||||
public Future<Path> answer(InvocationOnMock invoc)
|
||||
throws Throwable {
|
||||
Future<Path> done = mock(Future.class);
|
||||
when(done.isDone()).thenReturn(true);
|
||||
FakeDownload d = (FakeDownload) invoc.getArguments()[0];
|
||||
when(done.get()).thenReturn(d.call());
|
||||
return done;
|
||||
}
|
||||
});
|
||||
doReturn(syncExec).when(localizer).createDownloadThreadPool();
|
||||
doReturn(cs).when(localizer).createCompletionService(syncExec);
|
||||
|
||||
return localizer;
|
||||
}
|
||||
|
||||
static class HBMatches extends ArgumentMatcher<LocalizerStatus> {
|
||||
final LocalResource rsrc;
|
||||
HBMatches(LocalResource rsrc) {
|
||||
|
||||
@ -46,6 +46,7 @@
|
||||
import org.apache.hadoop.io.DataInputBuffer;
|
||||
import org.apache.hadoop.io.DataOutputBuffer;
|
||||
import org.apache.hadoop.security.Credentials;
|
||||
import org.apache.hadoop.security.UserGroupInformation;
|
||||
import org.apache.hadoop.yarn.YarnException;
|
||||
import org.apache.hadoop.yarn.api.protocolrecords.StartContainerRequest;
|
||||
import org.apache.hadoop.yarn.api.records.ApplicationAttemptId;
|
||||
@ -126,9 +127,9 @@ public void testLocalFileDeletionAfterUpload() throws Exception {
|
||||
EventHandler<ApplicationEvent> appEventHandler = mock(EventHandler.class);
|
||||
dispatcher.register(ApplicationEventType.class, appEventHandler);
|
||||
|
||||
LogAggregationService logAggregationService =
|
||||
LogAggregationService logAggregationService = spy(
|
||||
new LogAggregationService(dispatcher, this.context, this.delSrvc,
|
||||
super.dirsHandler);
|
||||
super.dirsHandler));
|
||||
logAggregationService.init(this.conf);
|
||||
logAggregationService.start();
|
||||
|
||||
@ -156,7 +157,9 @@ public void testLocalFileDeletionAfterUpload() throws Exception {
|
||||
application1));
|
||||
|
||||
logAggregationService.stop();
|
||||
|
||||
// ensure filesystems were closed
|
||||
verify(logAggregationService).closeFileSystems(
|
||||
any(UserGroupInformation.class));
|
||||
|
||||
String containerIdStr = ConverterUtils.toString(container11);
|
||||
File containerLogDir = new File(app1LogDir, containerIdStr);
|
||||
@ -380,7 +383,60 @@ public void testMultipleAppsLogAggregation() throws Exception {
|
||||
|
||||
@Test
|
||||
@SuppressWarnings("unchecked")
|
||||
public void testLogAggregationFailsWithoutKillingNM() throws Exception {
|
||||
public void testLogAggregationInitFailsWithoutKillingNM() throws Exception {
|
||||
|
||||
this.conf.set(YarnConfiguration.NM_LOG_DIRS,
|
||||
localLogDir.getAbsolutePath());
|
||||
this.conf.set(YarnConfiguration.NM_REMOTE_APP_LOG_DIR,
|
||||
this.remoteRootLogDir.getAbsolutePath());
|
||||
|
||||
DrainDispatcher dispatcher = createDispatcher();
|
||||
EventHandler<ApplicationEvent> appEventHandler = mock(EventHandler.class);
|
||||
dispatcher.register(ApplicationEventType.class, appEventHandler);
|
||||
|
||||
LogAggregationService logAggregationService = spy(
|
||||
new LogAggregationService(dispatcher, this.context, this.delSrvc,
|
||||
super.dirsHandler));
|
||||
logAggregationService.init(this.conf);
|
||||
logAggregationService.start();
|
||||
|
||||
ApplicationId appId = BuilderUtils.newApplicationId(
|
||||
System.currentTimeMillis(), (int)Math.random());
|
||||
doThrow(new YarnException("KABOOM!"))
|
||||
.when(logAggregationService).initAppAggregator(
|
||||
eq(appId), eq(user), any(Credentials.class),
|
||||
any(ContainerLogsRetentionPolicy.class), anyMap());
|
||||
|
||||
logAggregationService.handle(new LogHandlerAppStartedEvent(appId,
|
||||
this.user, null,
|
||||
ContainerLogsRetentionPolicy.AM_AND_FAILED_CONTAINERS_ONLY,
|
||||
this.acls));
|
||||
|
||||
dispatcher.await();
|
||||
ApplicationEvent expectedEvents[] = new ApplicationEvent[]{
|
||||
new ApplicationFinishEvent(appId,
|
||||
"Application failed to init aggregation: KABOOM!")
|
||||
};
|
||||
checkEvents(appEventHandler, expectedEvents, false,
|
||||
"getType", "getApplicationID", "getDiagnostic");
|
||||
// no filesystems instantiated yet
|
||||
verify(logAggregationService, never()).closeFileSystems(
|
||||
any(UserGroupInformation.class));
|
||||
|
||||
// verify trying to collect logs for containers/apps we don't know about
|
||||
// doesn't blow up and tear down the NM
|
||||
logAggregationService.handle(new LogHandlerContainerFinishedEvent(
|
||||
BuilderUtils.newContainerId(4, 1, 1, 1), 0));
|
||||
dispatcher.await();
|
||||
logAggregationService.handle(new LogHandlerAppFinishedEvent(
|
||||
BuilderUtils.newApplicationId(1, 5)));
|
||||
dispatcher.await();
|
||||
}
|
||||
|
||||
@Test
|
||||
@SuppressWarnings("unchecked")
|
||||
public void testLogAggregationCreateDirsFailsWithoutKillingNM()
|
||||
throws Exception {
|
||||
|
||||
this.conf.set(YarnConfiguration.NM_LOG_DIRS, localLogDir.getAbsolutePath());
|
||||
this.conf.set(YarnConfiguration.NM_REMOTE_APP_LOG_DIR,
|
||||
@ -399,10 +455,8 @@ public void testLogAggregationFailsWithoutKillingNM() throws Exception {
|
||||
ApplicationId appId = BuilderUtils.newApplicationId(
|
||||
System.currentTimeMillis(), (int)Math.random());
|
||||
doThrow(new YarnException("KABOOM!"))
|
||||
.when(logAggregationService).initAppAggregator(
|
||||
eq(appId), eq(user), any(Credentials.class),
|
||||
any(ContainerLogsRetentionPolicy.class), anyMap());
|
||||
|
||||
.when(logAggregationService).createAppDir(any(String.class),
|
||||
any(ApplicationId.class), any(UserGroupInformation.class));
|
||||
logAggregationService.handle(new LogHandlerAppStartedEvent(appId,
|
||||
this.user, null,
|
||||
ContainerLogsRetentionPolicy.AM_AND_FAILED_CONTAINERS_ONLY, this.acls));
|
||||
@ -413,6 +467,9 @@ public void testLogAggregationFailsWithoutKillingNM() throws Exception {
|
||||
};
|
||||
checkEvents(appEventHandler, expectedEvents, false,
|
||||
"getType", "getApplicationID", "getDiagnostic");
|
||||
// filesystems may have been instantiated
|
||||
verify(logAggregationService).closeFileSystems(
|
||||
any(UserGroupInformation.class));
|
||||
|
||||
// verify trying to collect logs for containers/apps we don't know about
|
||||
// doesn't blow up and tear down the NM
|
||||
@ -423,7 +480,7 @@ public void testLogAggregationFailsWithoutKillingNM() throws Exception {
|
||||
BuilderUtils.newApplicationId(1, 5)));
|
||||
dispatcher.await();
|
||||
}
|
||||
|
||||
|
||||
private void writeContainerLogs(File appLogDir, ContainerId containerId)
|
||||
throws IOException {
|
||||
// ContainerLogDir should be created
|
||||
|
||||
Loading…
Reference in New Issue
Block a user