big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-3682. MiniDFSCluster#init should provide more info when it fails. Contributed by Todd Lipcon

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1395385 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Eli Collins 2012-10-07 21:16:08 +00:00
parent d974127cf2
commit e32af6034b
2 changed files with 36 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
View File

@ -262,6 +262,9 @@ Release 2.0.3-alpha - Unreleased
HDFS-3483. Better error message when hdfs fsck is run against a ViewFS HDFS-3483. Better error message when hdfs fsck is run against a ViewFS
config. (Stephen Fritz via atm) config. (Stephen Fritz via atm)
HDFS-3682. MiniDFSCluster#init should provide more info when it fails.
(todd via eli)
OPTIMIZATIONS OPTIMIZATIONS
BUG FIXES BUG FIXES

39
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
View File

@ -624,14 +624,20 @@ private void initMiniDFSCluster(
} }
federation = nnTopology.isFederated(); federation = nnTopology.isFederated();
createNameNodesAndSetConf( try {
nnTopology, manageNameDfsDirs, manageNameDfsSharedDirs, createNameNodesAndSetConf(
enableManagedDfsDirsRedundancy, nnTopology, manageNameDfsDirs, manageNameDfsSharedDirs,
format, operation, clusterId, conf); enableManagedDfsDirsRedundancy,
format, operation, clusterId, conf);
} catch (IOException ioe) {
LOG.error("IOE creating namenodes. Permissions dump:\n" +
createPermissionsDiagnosisString(data_dir));
throw ioe;
}
if (format) { if (format) {
if (data_dir.exists() && !FileUtil.fullyDelete(data_dir)) { if (data_dir.exists() && !FileUtil.fullyDelete(data_dir)) {
throw new IOException("Cannot remove data directory: " + data_dir); throw new IOException("Cannot remove data directory: " + data_dir +
createPermissionsDiagnosisString(data_dir));
} }
} }
@ -647,6 +653,27 @@ private void initMiniDFSCluster(
ProxyUsers.refreshSuperUserGroupsConfiguration(conf); ProxyUsers.refreshSuperUserGroupsConfiguration(conf);
} }
/**
* @return a debug string which can help diagnose an error of why
* a given directory might have a permissions error in the context
* of a test case
*/
private String createPermissionsDiagnosisString(File path) {
StringBuilder sb = new StringBuilder();
while (path != null) {
sb.append("path '" + path + "': ").append("\n");
sb.append("\tabsolute:").append(path.getAbsolutePath()).append("\n");
sb.append("\tpermissions: ");
sb.append(path.isDirectory() ? "d": "-");
sb.append(path.canRead() ? "r" : "-");
sb.append(path.canWrite() ? "w" : "-");
sb.append(path.canExecute() ? "x" : "-");
sb.append("\n");
path = path.getParentFile();
}
return sb.toString();
}
private void createNameNodesAndSetConf(MiniDFSNNTopology nnTopology, private void createNameNodesAndSetConf(MiniDFSNNTopology nnTopology,
boolean manageNameDfsDirs, boolean manageNameDfsSharedDirs, boolean manageNameDfsDirs, boolean manageNameDfsSharedDirs,
boolean enableManagedDfsDirsRedundancy, boolean format, boolean enableManagedDfsDirsRedundancy, boolean format,