big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

YARN-10296. Make ContainerPBImpl#getId/setId synchronized. Contributed by Benjamin Teke

Browse Source
This commit is contained in:
Szilard Nemeth 2020-06-10 18:00:21 +02:00
parent 043628dcf1
commit e35f619841
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ContainerPBImpl.java
View File

@ -68,7 +68,7 @@ public ContainerPBImpl(ContainerProto proto) {
viaProto = true; viaProto = true;
} }
public ContainerProto getProto() { synchronized public ContainerProto getProto() {
mergeLocalToProto(); mergeLocalToProto();
proto = viaProto ? proto : builder.build(); proto = viaProto ? proto : builder.build();
@ -142,7 +142,7 @@ private void maybeInitBuilder() {
} }
@Override @Override
public ContainerId getId() { synchronized public ContainerId getId() {
ContainerProtoOrBuilder p = viaProto ? proto : builder; ContainerProtoOrBuilder p = viaProto ? proto : builder;
if (this.containerId != null) { if (this.containerId != null) {
return this.containerId; return this.containerId;
@ -176,7 +176,7 @@ public NodeId getNodeId() {
} }
@Override @Override
public void setId(ContainerId id) { synchronized public void setId(ContainerId id) {
maybeInitBuilder(); maybeInitBuilder();
if (id == null) if (id == null)
builder.clearId(); builder.clearId();