From e89ac4b07740f977fb1354094381d2460e69f503 Mon Sep 17 00:00:00 2001
From: Devaraj Das <ddas@apache.org>
Date: Mon, 14 Jun 2010 20:02:56 +0000
Subject: [PATCH] HADOOP-6652. Removes the unnecessary cache from
 ShellBasedUnixGroupsMapping. Contributed by Devaraj Das.

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@954612 13f79535-47bb-0310-9956-ffa450edef68
---
 CHANGES.txt                                              | 3 +++
 .../hadoop/security/ShellBasedUnixGroupsMapping.java     | 9 +--------
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/CHANGES.txt b/CHANGES.txt
index 13e9d404db..bc2000db2c 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -88,6 +88,9 @@ Trunk (unreleased changes)
     HADOOP-6682. NetUtils:normalizeHostName does not process hostnames starting
     with [a-f] correctly. (jghoman)
 
+    HADOOP-6652. Removes the unnecessary cache from ShellBasedUnixGroupsMapping.
+    (ddas)
+
 Release 0.21.0 - Unreleased
 
   INCOMPATIBLE CHANGES
diff --git a/src/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java b/src/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java
index 505864d24b..f5fc7101fc 100644
--- a/src/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java
+++ b/src/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java
@@ -39,19 +39,12 @@ import org.apache.hadoop.util.Shell.ExitCodeException;
 @InterfaceAudience.LimitedPrivate({"HDFS", "MapReduce"})
 @InterfaceStability.Evolving
 public class ShellBasedUnixGroupsMapping implements GroupMappingServiceProvider {
-  Map<String, List<String>> userGroups = 
-    new ConcurrentHashMap<String, List<String>>();
   
   private static final Log LOG = LogFactory.getLog(ShellBasedUnixGroupsMapping.class);
   
   @Override
   public List<String> getGroups(String user) throws IOException {
-    List<String> groups = userGroups.get(user);
-    if (groups == null) {
-      groups = getUnixGroups(user);
-      userGroups.put(user, groups);
-    }
-    return groups;
+    return getUnixGroups(user);
   }
 
   /**