big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MAPREDUCE-7093. Use assertEquals instead of assertTrue(a == b) in TestMapReduceJobControlWithMocks

Browse Source 
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
This commit is contained in:
Abhishek Modi 2018-05-07 01:15:14 +09:00 committed by Akira Ajisaka
parent a732acd873
commit e9159db623
No known key found for this signature in database
GPG Key ID: C1EDBB9CA400FD50
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol/TestMapReduceJobControlWithMocks.java
View File

@ -19,7 +19,6 @@
package org.apache.hadoop.mapreduce.lib.jobcontrol;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
@ -52,10 +51,10 @@ public void testSuccessfulJobs() throws Exception {
assertEquals("Success list", 4, jobControl.getSuccessfulJobList().size());
assertEquals("Failed list", 0, jobControl.getFailedJobList().size());
assertTrue(job1.getJobState() == ControlledJob.State.SUCCESS);
assertTrue(job2.getJobState() == ControlledJob.State.SUCCESS);
assertTrue(job3.getJobState() == ControlledJob.State.SUCCESS);
assertTrue(job4.getJobState() == ControlledJob.State.SUCCESS);
assertEquals(ControlledJob.State.SUCCESS, job1.getJobState());
assertEquals(ControlledJob.State.SUCCESS, job2.getJobState());
assertEquals(ControlledJob.State.SUCCESS, job3.getJobState());
assertEquals(ControlledJob.State.SUCCESS, job4.getJobState());
jobControl.stop();
}
@ -74,10 +73,10 @@ public void testFailedJob() throws Exception {
assertEquals("Success list", 1, jobControl.getSuccessfulJobList().size());
assertEquals("Failed list", 3, jobControl.getFailedJobList().size());
assertTrue(job1.getJobState() == ControlledJob.State.FAILED);
assertTrue(job2.getJobState() == ControlledJob.State.SUCCESS);
assertTrue(job3.getJobState() == ControlledJob.State.DEPENDENT_FAILED);
assertTrue(job4.getJobState() == ControlledJob.State.DEPENDENT_FAILED);
assertEquals(ControlledJob.State.FAILED, job1.getJobState());
assertEquals(ControlledJob.State.SUCCESS, job2.getJobState());
assertEquals(ControlledJob.State.DEPENDENT_FAILED, job3.getJobState());
assertEquals(ControlledJob.State.DEPENDENT_FAILED, job4.getJobState());
jobControl.stop();
}
@ -99,7 +98,7 @@ public void testErrorWhileSubmitting() throws Exception {
assertEquals("Success list", 0, jobControl.getSuccessfulJobList().size());
assertEquals("Failed list", 1, jobControl.getFailedJobList().size());
assertTrue(job1.getJobState() == ControlledJob.State.FAILED);
assertEquals(ControlledJob.State.FAILED, job1.getJobState());
} finally {
jobControl.stop();
}