big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-11827. NPE is thrown when log level changed in BlockPlacementPolicyDefault#chooseRandom() method. Contributed by xupeng.

Browse Source
This commit is contained in:
Arpit Agarwal 2017-05-16 19:51:04 -07:00
parent 18c494a00c
commit ec21ce425f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java
View File

@ -735,7 +735,7 @@ protected DatanodeStorageInfo chooseRandom(int numOfReplicas,
} }
Preconditions.checkState(excludedNodes.add(chosenNode), "chosenNode " Preconditions.checkState(excludedNodes.add(chosenNode), "chosenNode "
+ chosenNode + " is already in excludedNodes " + excludedNodes); + chosenNode + " is already in excludedNodes " + excludedNodes);
if (LOG.isDebugEnabled()) { if (LOG.isDebugEnabled() && builder != null) {
builder.append("\nNode ").append(NodeBase.getPath(chosenNode)) builder.append("\nNode ").append(NodeBase.getPath(chosenNode))
.append(" ["); .append(" [");
} }
@ -771,7 +771,7 @@ protected DatanodeStorageInfo chooseRandom(int numOfReplicas,
} }
} }
if (LOG.isDebugEnabled()) { if (LOG.isDebugEnabled() && builder != null) {
builder.append("\n]"); builder.append("\n]");
} }