big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HADOOP-10296. Incorrect null check in SwiftRestClient#buildException(). Contributed by Rahul Palamuttam and Kanaka Kumar Avvaru.

Browse Source
This commit is contained in:
Akira Ajisaka 2015-10-01 18:25:31 +02:00
parent 195793c6f3
commit ecbfd68974
2 changed files with 4 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-common-project/hadoop-common/CHANGES.txt
View File

@ -1103,6 +1103,9 @@ Release 2.8.0 - UNRELEASED
HADOOP-12448. TestTextCommand: use mkdirs rather than mkdir to create test HADOOP-12448. TestTextCommand: use mkdirs rather than mkdir to create test
directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) directory. (Contributed by Colin Patrick McCabe and Chris Nauroth)
HADOOP-10296. Incorrect null check in SwiftRestClient#buildException().
(Rahul Palamuttam and Kanaka Kumar Avvaru via aajisaka)
OPTIMIZATIONS OPTIMIZATIONS
HADOOP-12051. ProtobufRpcEngine.invoke() should use Exception.toString() HADOOP-12051. ProtobufRpcEngine.invoke() should use Exception.toString()

20
hadoop-tools/hadoop-openstack/src/main/java/org/apache/hadoop/fs/swift/http/SwiftRestClient.java
View File

@ -172,8 +172,6 @@ public final class SwiftRestClient {
*/ */
private URI objectLocationURI; private URI objectLocationURI;
private final URI filesystemURI;
/** /**
* The name of the service provider * The name of the service provider
*/ */
@ -237,13 +235,6 @@ private synchronized URI getEndpointURI() {
return endpointURI; return endpointURI;
} }
/**
* object location endpoint
*/
private synchronized URI getObjectLocationURI() {
return objectLocationURI;
}
/** /**
* token for Swift communication * token for Swift communication
*/ */
@ -331,13 +322,6 @@ protected final GetMethod doCreateMethod(String uri) {
} }
} }
private static abstract class PostMethodProcessor<R> extends HttpMethodProcessor<PostMethod, R> {
@Override
protected final PostMethod doCreateMethod(String uri) {
return new PostMethod(uri);
}
}
/** /**
* There's a special type for auth messages, so that low-level * There's a special type for auth messages, so that low-level
* message handlers can react to auth failures differently from everything * message handlers can react to auth failures differently from everything
@ -449,7 +433,6 @@ protected final HeadMethod doCreateMethod(String uri) {
private SwiftRestClient(URI filesystemURI, private SwiftRestClient(URI filesystemURI,
Configuration conf) Configuration conf)
throws SwiftConfigurationException { throws SwiftConfigurationException {
this.filesystemURI = filesystemURI;
Properties props = RestClientBindings.bind(filesystemURI, conf); Properties props = RestClientBindings.bind(filesystemURI, conf);
String stringAuthUri = getOption(props, SWIFT_AUTH_PROPERTY); String stringAuthUri = getOption(props, SWIFT_AUTH_PROPERTY);
username = getOption(props, SWIFT_USERNAME_PROPERTY); username = getOption(props, SWIFT_USERNAME_PROPERTY);
@ -1129,7 +1112,6 @@ public AccessToken extractResult(AuthPostMethod method) throws IOException {
final List<Catalog> serviceCatalog = access.getServiceCatalog(); final List<Catalog> serviceCatalog = access.getServiceCatalog();
//locate the specific service catalog that defines Swift; variations //locate the specific service catalog that defines Swift; variations
//in the name of this add complexity to the search //in the name of this add complexity to the search
boolean catalogMatch = false;
StringBuilder catList = new StringBuilder(); StringBuilder catList = new StringBuilder();
StringBuilder regionList = new StringBuilder(); StringBuilder regionList = new StringBuilder();
@ -1470,7 +1452,7 @@ private <M extends HttpMethod> IOException buildException(URI uri,
//and the result //and the result
Header availableContentRange = method.getResponseHeader( Header availableContentRange = method.getResponseHeader(
HEADER_CONTENT_RANGE); HEADER_CONTENT_RANGE);
if (requestContentLen!=null) { if (availableContentRange != null) {
errorText.append(" available ").append(availableContentRange.getValue()); errorText.append(" available ").append(availableContentRange.getValue());
} }
fault = new EOFException(errorText.toString()); fault = new EOFException(errorText.toString());