big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

YARN-5921. Incorrect synchronization in RMContextImpl#setHAServiceState/getHAServiceState. Contributed by Varun Saxena

Browse Source
This commit is contained in:
Naganarasimha 2016-12-06 06:53:38 +05:30
parent dcedb72af4
commit f3b8ff54ab
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMContextImpl.java
View File

@ -80,6 +80,8 @@ public class RMContextImpl implements RMContext {
private QueueLimitCalculator queueLimitCalculator;
private final Object haServiceStateLock = new Object();
/**
* Default constructor. To be used in conjunction with setter methods for
* individual fields.
@ -254,9 +256,9 @@ void setHAEnabled(boolean isHAEnabled) {
this.isHAEnabled = isHAEnabled;
}
void setHAServiceState(HAServiceState haServiceState) {
synchronized (haServiceState) {
this.haServiceState = haServiceState;
void setHAServiceState(HAServiceState serviceState) {
synchronized (haServiceStateLock) {
this.haServiceState = serviceState;
}
}
@ -352,7 +354,7 @@ public boolean isHAEnabled() {
@Override
public HAServiceState getHAServiceState() {
synchronized (haServiceState) {
synchronized (haServiceStateLock) {
return haServiceState;
}
}