From fa75e35f9ec42e94ed017e2fe955affd33be0d8d Mon Sep 17 00:00:00 2001 From: Eli Collins Date: Thu, 2 Sep 2010 06:26:43 +0000 Subject: [PATCH] HADOOP-6934. Test for ByteWritable comparator. Contributed by Johannes Zillmann. git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@991821 13f79535-47bb-0310-9956-ffa450edef68 --- CHANGES.txt | 3 ++ .../apache/hadoop/io/TestBooleanWritable.java | 53 +++++++++++++++++++ 2 files changed, 56 insertions(+) create mode 100644 src/test/core/org/apache/hadoop/io/TestBooleanWritable.java diff --git a/CHANGES.txt b/CHANGES.txt index 0ed77a8566..41bd19fa0b 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -125,6 +125,9 @@ Trunk (unreleased changes) HADOOP-6803. Add native gzip read/write coverage to TestCodec. (Eli Collins via tomwhite) + HADOOP-6934. Test for ByteWritable comparator. + (Johannes Zillmann via Eli Collins) + OPTIMIZATIONS HADOOP-6884. Add LOG.isDebugEnabled() guard for each LOG.debug(..). diff --git a/src/test/core/org/apache/hadoop/io/TestBooleanWritable.java b/src/test/core/org/apache/hadoop/io/TestBooleanWritable.java new file mode 100644 index 0000000000..8d49425c08 --- /dev/null +++ b/src/test/core/org/apache/hadoop/io/TestBooleanWritable.java @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.io; + +import java.io.IOException; + +import org.junit.Test; +import static org.junit.Assert.*; + +public class TestBooleanWritable { + + @Test + public void testCompareUnequalWritables() throws Exception { + DataOutputBuffer bTrue = writeWritable(new BooleanWritable(true)); + DataOutputBuffer bFalse = writeWritable(new BooleanWritable(false)); + WritableComparator writableComparator = + WritableComparator.get(BooleanWritable.class); + + assertEquals(0, compare(writableComparator, bTrue, bTrue)); + assertEquals(0, compare(writableComparator, bFalse, bFalse)); + assertEquals(1, compare(writableComparator, bTrue, bFalse)); + assertEquals(-1, compare(writableComparator, bFalse, bTrue)); + } + + private int compare(WritableComparator writableComparator, + DataOutputBuffer buf1, DataOutputBuffer buf2) { + return writableComparator.compare(buf1.getData(), 0, buf1.size(), + buf2.getData(), 0, buf2.size()); + } + + protected DataOutputBuffer writeWritable(Writable writable) + throws IOException { + DataOutputBuffer out = new DataOutputBuffer(1024); + writable.write(out); + out.flush(); + return out; + } +}