big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-13664. Refactor ConfiguredFailoverProxyProvider to make inheritance easier. Contributed by Chao Sun.

Browse Source
This commit is contained in:
Chao Sun 2018-06-08 16:36:42 -07:00 committed by Konstantin V Shvachko
parent cf4108313d
commit fba1c42adc
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ConfiguredFailoverProxyProvider.java
View File

@ -52,11 +52,11 @@ public class ConfiguredFailoverProxyProvider<T> extends
protected final Configuration conf; protected final Configuration conf;
protected final List<AddressRpcProxyPair<T>> proxies = protected final List<AddressRpcProxyPair<T>> proxies =
new ArrayList<AddressRpcProxyPair<T>>(); new ArrayList<AddressRpcProxyPair<T>>();
private final UserGroupInformation ugi; protected final UserGroupInformation ugi;
protected final Class<T> xface; protected final Class<T> xface;
private int currentProxyIndex = 0; private int currentProxyIndex = 0;
private final HAProxyFactory<T> factory; protected final HAProxyFactory<T> factory;
public ConfiguredFailoverProxyProvider(Configuration conf, URI uri, public ConfiguredFailoverProxyProvider(Configuration conf, URI uri,
Class<T> xface, HAProxyFactory<T> factory) { Class<T> xface, HAProxyFactory<T> factory) {
@ -122,6 +122,10 @@ public Class<T> getInterface() {
@Override @Override
public synchronized ProxyInfo<T> getProxy() { public synchronized ProxyInfo<T> getProxy() {
AddressRpcProxyPair<T> current = proxies.get(currentProxyIndex); AddressRpcProxyPair<T> current = proxies.get(currentProxyIndex);
return getProxy(current);
}
protected ProxyInfo<T> getProxy(AddressRpcProxyPair<T> current) {
if (current.namenode == null) { if (current.namenode == null) {
try { try {
current.namenode = factory.createProxy(conf, current.namenode = factory.createProxy(conf,
@ -147,7 +151,7 @@ synchronized void incrementProxyIndex() {
* A little pair object to store the address and connected RPC proxy object to * A little pair object to store the address and connected RPC proxy object to
* an NN. Note that {@link AddressRpcProxyPair#namenode} may be null. * an NN. Note that {@link AddressRpcProxyPair#namenode} may be null.
*/ */
private static class AddressRpcProxyPair<T> { protected static class AddressRpcProxyPair<T> {
public final InetSocketAddress address; public final InetSocketAddress address;
public T namenode; public T namenode;