81d90fd65b
This patch migrates the S3A connector to use the V2 AWS SDK. This is a significant change at the source code level. Any applications using the internal extension/override points in the filesystem connector are likely to break. This includes but is not limited to: - Code invoking methods on the S3AFileSystem class which used classes from the V1 SDK. - The ability to define the factory for the `AmazonS3` client, and to retrieve it from the S3AFileSystem. There is a new factory API and a special interface S3AInternals to access a limited set of internal classes and operations. - Delegation token and auditing extensions. - Classes trying to integrate with the AWS SDK. All standard V1 credential providers listed in the option fs.s3a.aws.credentials.provider will be automatically remapped to their V2 equivalent. Other V1 Credential Providers are supported, but only if the V1 SDK is added back to the classpath. The SDK Signing plugin has changed; all v1 signers are incompatible. There is no support for the S3 "v2" signing algorithm. Finally, the aws-sdk-bundle JAR has been replaced by the shaded V2 equivalent, "bundle.jar", which is now exported by the hadoop-aws module. Consult the document aws_sdk_upgrade for the full details. Contributed by Ahmar Suhail + some bits by Steve Loughran
95 lines
3.4 KiB
XML
95 lines
3.4 KiB
XML
<!--
|
|
Licensed to the Apache Software Foundation (ASF) under one or more
|
|
contributor license agreements. See the NOTICE file distributed with
|
|
this work for additional information regarding copyright ownership.
|
|
The ASF licenses this file to You under the Apache License, Version 2.0
|
|
(the "License"); you may not use this file except in compliance with
|
|
the License. You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
<FindBugsFilter>
|
|
|
|
<!-- same code as in FileSystem is triggering the same warning. -->
|
|
<Match>
|
|
<Class name="org.apache.hadoop.fs.s3native.S3xLoginHelper" />
|
|
<Method name="checkPath" />
|
|
<Bug pattern="ES_COMPARING_STRINGS_WITH_EQ" />
|
|
</Match>
|
|
<!-- Redundant null check makes code clearer, future-proof here. -->
|
|
<Match>
|
|
<Class name="org.apache.hadoop.fs.s3a.S3AFileSystem" />
|
|
<Method name="s3Exists" />
|
|
<Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" />
|
|
</Match>
|
|
<!-- we are using completable futures, so ignore the Future which submit() returns -->
|
|
<Match>
|
|
<Class name="org.apache.hadoop.fs.s3a.S3AFileSystem$InputStreamCallbacksImpl" />
|
|
<Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" />
|
|
</Match>
|
|
|
|
<!--
|
|
findbugs gets confused by lambda expressions in synchronized methods
|
|
and considers references to fields to be unsynchronized.
|
|
As you can't disable the methods individually, we have to disable
|
|
them for the entire class.
|
|
-->
|
|
<Match>
|
|
<Class name="org.apache.hadoop.fs.s3a.S3AInputStream"/>
|
|
<Bug pattern="IS2_INCONSISTENT_SYNC"/>
|
|
</Match>
|
|
<!--
|
|
findbugs reporting RV ignored. Not true.
|
|
"Return value of S3AReadOpContext.getReadInvoker() ignored,
|
|
but method has no side effect"
|
|
-->
|
|
<Match>
|
|
<Class name="org.apache.hadoop.fs.s3a.S3AInputStream"/>
|
|
<Method name="reopen"/>
|
|
<Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"/>
|
|
</Match>
|
|
<Match>
|
|
<Class name="org.apache.hadoop.fs.s3a.S3AFileSystem"/>
|
|
<Method name="openFileWithOptions"/>
|
|
<Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
|
|
</Match>
|
|
<Match>
|
|
<Class name="org.apache.hadoop.fs.s3a.S3AFileSystem"/>
|
|
<Field name="futurePool"/>
|
|
<Bug pattern="IS2_INCONSISTENT_SYNC"/>
|
|
</Match>
|
|
<Match>
|
|
<Class name="org.apache.hadoop.fs.s3a.S3AFileSystem"/>
|
|
<Field name="s3AsyncClient"/>
|
|
<Bug pattern="IS2_INCONSISTENT_SYNC"/>
|
|
</Match>
|
|
<Match>
|
|
<Class name="org.apache.hadoop.fs.s3a.s3guard.S3GuardTool$BucketInfo"/>
|
|
<Method name="run"/>
|
|
<Bug pattern="SF_SWITCH_FALLTHROUGH"/>
|
|
</Match>
|
|
|
|
<!--
|
|
Some of the S3A Instrumentation classes increment volatile references from
|
|
within synchronized contexts; they use volatile to keep the cost
|
|
of these updates and reading them down.
|
|
-->
|
|
<Match>
|
|
<Class name="org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl"/>
|
|
<Bug pattern="VO_VOLATILE_INCREMENT"/>
|
|
</Match>
|
|
|
|
<!-- Ignore return value from this method call -->
|
|
<Match>
|
|
<Class name="org.apache.hadoop.fs.s3a.impl.StoreContext"/>
|
|
<Method name="submit"/>
|
|
<Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
|
|
</Match>
|
|
</FindBugsFilter>
|