From f14108361b23f20d38dbc13dc8cc11b6fef33f0c Mon Sep 17 00:00:00 2001 From: Pieter Noordhuis Date: Fri, 26 Nov 2010 14:47:01 +0100 Subject: [PATCH] Reply objects don't need to be calloc'ed --- hiredis.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hiredis.c b/hiredis.c index f50b046..6db1075 100644 --- a/hiredis.c +++ b/hiredis.c @@ -70,7 +70,7 @@ static redisReplyObjectFunctions defaultFunctions = { /* Create a reply object */ static redisReply *createReplyObject(int type) { - redisReply *r = calloc(sizeof(*r),1); + redisReply *r = malloc(sizeof(*r)); if (!r) redisOOM(); r->type = type; @@ -90,9 +90,10 @@ void freeReplyObject(void *reply) { if (r->element[j]) freeReplyObject(r->element[j]); free(r->element); break; - default: - if (r->str != NULL) - free(r->str); + case REDIS_REPLY_ERROR: + case REDIS_REPLY_STATUS: + case REDIS_REPLY_STRING: + free(r->str); break; } free(r);